Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Distributed Context API (distributed http context) #31393

Closed
tarekgh opened this issue Nov 4, 2019 · 6 comments
Closed

Introduce Distributed Context API (distributed http context) #31393

tarekgh opened this issue Nov 4, 2019 · 6 comments
Labels
area-System.Diagnostics enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@tarekgh
Copy link
Member

tarekgh commented Nov 4, 2019

This issue tracking the work as the part of the issue #31372

Distributed context should support

  • string/string (key-value pairs)
  • Support scoping
  • Not attached to Activity
@SergeyKanzhelev
Copy link

This change may include the following aspects:

  1. Activity.Baggage can be re-wired to use this context API instead of associating context with Activity: https://github.com/dotnet/corefx/issues/30333
  2. ASP.NET ILogger scopes can be sharing the same AsyncLocal for scopes tracking. This way ILogger logs may be correlated with the distributed scope more natively.

Scopes must be enclosed and allow inheritance of key/value pairs. So child scope have all parent scope key/value pairs available. As well as child scopes may completely re-start the scope with no values or remove (hide) certain keys from the parent scope.

@Aaronontheweb
Copy link

Why not just take a dependency on the OpenTracing or OpenTelemetry packages here?

@tarekgh
Copy link
Member Author

tarekgh commented Nov 19, 2019

@Aaronontheweb .NET Libraries trying to not taking dependency on OOB packages because this create a lot of problems related to package versioning and security fixes.

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the Future milestone Feb 1, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Apr 6, 2020
@tarekgh tarekgh modified the milestones: Future, 5.0 May 4, 2020
@tarekgh tarekgh modified the milestones: 5.0, Future May 30, 2020
@danmoseley
Copy link
Member

@tarekgh I found this one in https://themesof.net/?q=is:open%20kinds:teui as it was under a (closed) Epic. Do you believe it is properly part of the .NET 6 wave? I added it to the Cloud Native Epic instead so it is a sibling of your Metrics story, but I am not sure whether it is really part of .NET 6. If so we should remove its parenting or possibly close it.

@tarekgh
Copy link
Member Author

tarekgh commented Nov 24, 2020

@danmosemsft No this issue is not part of 6.0 planning and I am not aware of anyone need it urgently. I'll close it.

@tarekgh tarekgh closed this as completed Nov 24, 2020
@danmoseley
Copy link
Member

thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Diagnostics enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

7 participants