Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Threading.Tasks.Tests.CESchedulerPairTests failing with TypeLoadException on CoreCLR #32126

Closed
jkoritzinsky opened this issue Feb 11, 2020 · 2 comments · Fixed by #32153
Closed

System.Threading.Tasks.Tests.CESchedulerPairTests failing with TypeLoadException on CoreCLR #32126

jkoritzinsky opened this issue Feb 11, 2020 · 2 comments · Fixed by #32153
Labels
area-System.Threading.Tasks blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' runtime-coreclr specific to the CoreCLR runtime

Comments

@jkoritzinsky
Copy link
Member

The System.ThreadTasks.Tests.CESchedulerPairTests tests are failing with a TypeLoadException as follows:

System.TypeLoadException : Could not load type 'System.Threading.Tasks.SingleProducerSingleConsumerQueue`1+Segment[System.__Canon]' from assembly 'System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'.

Example build: https://dev.azure.com/dnceng/public/_build/results?buildId=516148&view=ms.vss-test-web.build-test-results-tab&runId=16342246&resultId=159245&paneView=debug

cc: @dotnet/runtime-infrastructure
@jkoritzinsky jkoritzinsky added area-System.Threading.Tasks blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' runtime-coreclr specific to the CoreCLR runtime labels Feb 11, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 11, 2020
@jkoritzinsky jkoritzinsky mentioned this issue Feb 11, 2020
Merged
@safern
Copy link
Member

safern commented Feb 11, 2020

See discussion here: #32083 (comment)

Trying to figure out which change caused this.

@safern
Copy link
Member

safern commented Feb 12, 2020

@janvorli @jkotas it seems like this is the change that caused this test regression: #31956

The reason why it didn't fail on the PR is because it is a flaky failure. Locally I was able to repro and it failed 1 out of 3 runs pretty much all the time. The most runs I saw without a failure was 8. However when I reverted that commit locally, it has done 40 runs with no failures since I reverted it.

@jkotas do you want me to revert and send a PR in the meantime to get a clean CI?

@safern safern mentioned this issue Feb 12, 2020
Merged
@jkotas jkotas mentioned this issue Feb 12, 2020
Merged
@GrabYourPitchforks GrabYourPitchforks mentioned this issue Feb 12, 2020
Merged
@marek-safar marek-safar mentioned this issue Feb 12, 2020
Merged
@jkotas jkotas mentioned this issue Feb 12, 2020
Merged
@stephentoub stephentoub removed the untriaged New issue has not been triaged by the area owner label Apr 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Threading.Tasks blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Display stack trace at stack overflow (#31956)" safern/runtime
4 participants
@jkoritzinsky @stephentoub @safern @Dotnet-GitSync-Bot