-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Fallback CoreCLR build to OSX/x64 when building for iOS #32662
Comments
That does not sound like the right approach to me. We should not building CoreCLR at all when building for iOS. |
@jkotas I agree but the libraries build requires CoreCLR at the moment. |
What does the libraries build require from CoreCLR? |
It should be just |
I haven't looked into that but if it's trivial then yeah we should go that way instead. @ViktorHofer can you take a look? |
From what I've seen it requires |
There's more logic that checks for CoreCLR artifacts like this one: runtime/eng/liveBuilds.targets Line 91 in 58cf146
I'm not sure if it's the only place. |
We also need the Microsoft.NET.Sdk.IL (ilasm, ildasm) |
Is it just ilasm / ildasm? If so, can we use a fixed version for them? |
I believe we aren't using a live version yet, so this shouldn't be an issue at the moment: #1137. |
Ok, given that the fallback approach isn't desirable and we should instead fix the libraries build to no longer require CoreCLR let's continue the discussion in #32613. |
I'm working on a branch that adds an iOS target OS to the build system.
This causes an issue for the CoreCLR build because it doesn't know how to build for that target and until #32613 is fixed we need the CoreCLR build for the libraries build.
My current thinking was that the build can simply fallback to OSX.x64 in that case as it's the only platform where iOS can be built. I've implemented that in akoeplinger@23cca6b.
@ViktorHofer asked me to open a discussion issue so we can decide whether that is the correct approach and get some input from @jkotas.
The text was updated successfully, but these errors were encountered: