-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ObsoleteAttribute #33089
Labels
Milestone
Comments
terrajobst
added
api-ready-for-review
blocked
Issue/PR is blocked on something - see comments
labels
Mar 3, 2020
Dotnet-GitSync-Bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Mar 3, 2020
terrajobst
added
blocking
Marks issues that we want to fast track in order to unblock other important work
and removed
blocked
Issue/PR is blocked on something - see comments
labels
Mar 3, 2020
terrajobst
added
api-approved
API was approved in API review, it can be implemented
and removed
api-ready-for-review
labels
Mar 3, 2020
terrajobst
removed
the
blocking
Marks issues that we want to fast track in order to unblock other important work
label
Mar 6, 2020
Resolved by #33248 |
BTW I'm experimenting with using the UrlFormat property for new obsolete messages, and it's running afoul of CA2243. Severity Code Description Project File Line Suppression State
Error CA2243 In the constructor of 'ObsoleteAttribute', change the value of argument 'ObsoleteAttribute.UrlFormat', which is currently "https://aka.ms/dotnet-obsoletions/fill-me-in/{0}", to something that can be correctly parsed as 'Uri'. System.Runtime.Serialization.Formatters (net5.0-Unix), System.Runtime.Serialization.Formatters (net5.0-Windows_NT) C:\runtime.titan\src\libraries\System.Runtime.Serialization.Formatters\src\System\Runtime\Serialization\Formatters\Binary\BinaryFormatter.cs 41 Active We should update CA2243 to be aware of this particular property and to ignore it, or we should suppress CA2243 globally throughout the runtime repo, or we should rename the property to something other than UrlFormat. Any preference as to these courses of action? |
ghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
We'd like to make obsoletion more viable. This requires extending the
ObsoleteAttribute
:API
Usage
The text was updated successfully, but these errors were encountered: