Nullability issues with latest arcade update which updates the compiler

[ViktorHofer]

I don't have the errors anymore but it's easy to repro by upgrading the Arcade SDK.

cc @safern

[GrabYourPitchforks]

The nullability problems that were affecting us previously should be resolved. But we can't remove this line just yet, as it seems to trip an assert within Roslyn itself, resulting in a build failure. See dotnet/roslyn#44000 for more information.

[jcouv]

dotnet/roslyn#44000 was fixed. New build should be forthcoming.

[safern]

@GrabYourPitchforks thanks for working on this, ok to assign to you instead?

[GrabYourPitchforks]

Sure, assign me. Per a comment on the other PR I'll pin our toolset to the latest Roslyn nightlies. Will leave this tracking issue open so that once the fixed build makes its way through to Arcade, we can remove our override entirely.

[safern]

Makes sense to me, thanks for working on this 😄

[ViktorHofer]

@GrabYourPitchforks FYI I think an arcade update is in with a new compiler.

[GrabYourPitchforks]

Great! I'm heads-down on other work right now, but if anybody wants please feel free to reassign this issue to yourself. Otherwise I'll get to it when I get some cycles again.