-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and update THIRD-PARTY-NOTICES.TXT #3619
Comments
I wrote a scraper that merges in extra sections from various repos, and it triples the size of the TPN file we have right now. I haven't looked too deeply at it, but it seems to have copied things over with reasonable formatting. (Formatting is different between repos and even within each TPN file, so it's not pretty.) Here's the file: https://gist.github.com/dagood/73e517568cbef760e3781af54c5bc971 List of new sections and which TPN file they come from, and the repos I pulled from: https://gist.github.com/dagood/83233be851751c75e320359fb5858d14 An issue here is that Core-Setup is responsible for putting down "the" TPN at e.g. @leecow, @richlander, is this expected? Is the above TPN a reasonable change? /cc @dleeapho |
I don't know enough to have an informed opinion on if this satisfies requirements. The formatting seems fine. It does seem strange to have Asp.Net, DotNetTools, IIS-Common, IIS-Setup, MSBuildLocator and dotnet-install.ps1 (.sh is not included). Do we typically include our own components in the TPN? |
ASP.NET comes from CoreFX adding it here: https://github.com/dotnet/corefx/pull/38324/files, DotNetTools from https://github.com/dotnet/roslyn/pull/29403/files#diff-fa732c8fac311b142a7fa1c4f3fde1a9, and so on... can trace it back from the data in the third link. Everything added is in at least one TPN in some repo. |
@NikolaMilosavljevic, please run the tool and create PR for review of contents and formatting. |
All repo owners should be included in review. @nakarnam |
It doesn't look like I linked to my tooling anywhere--it's over here: It needs to be ported into https://github.com/dotnet/runtime/tree/master/tools-local/tasks/installer.tasks to be maintainable. |
@NikolaMilosavljevic any update on this one ? |
Can close this after we merge #42989 |
Closing via #42989 |
Review and update repo THIRD-PARTY-NOTICES.TXT as appropriate. Work should be completed for Preview 7.
The text was updated successfully, but these errors were encountered: