Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update THIRD-PARTY-NOTICES.TXT #3619

Closed
leecow opened this issue Jun 4, 2019 · 9 comments · Fixed by #41851
Closed

Review and update THIRD-PARTY-NOTICES.TXT #3619

leecow opened this issue Jun 4, 2019 · 9 comments · Fixed by #41851

Comments

@leecow
Copy link
Member

leecow commented Jun 4, 2019

Review and update repo THIRD-PARTY-NOTICES.TXT as appropriate. Work should be completed for Preview 7.

@dagood
Copy link
Member

dagood commented Aug 28, 2019

I wrote a scraper that merges in extra sections from various repos, and it triples the size of the TPN file we have right now. I haven't looked too deeply at it, but it seems to have copied things over with reasonable formatting. (Formatting is different between repos and even within each TPN file, so it's not pretty.)

Here's the file: https://gist.github.com/dagood/73e517568cbef760e3781af54c5bc971
Diff: https://gist.github.com/dagood/d5f3abff3eec3f222def369798198ac3

List of new sections and which TPN file they come from, and the repos I pulled from: https://gist.github.com/dagood/83233be851751c75e320359fb5858d14

An issue here is that Core-Setup is responsible for putting down "the" TPN at e.g. C:\Program Files\dotnet\ThirdPartyNotices.txt. Additional runtimes and the SDK don't put down their own TPNs, so it seems to fall to Core-Setup to include everything.


@leecow, @richlander, is this expected? Is the above TPN a reasonable change?

/cc @dleeapho

@leecow
Copy link
Member Author

leecow commented Sep 5, 2019

I don't know enough to have an informed opinion on if this satisfies requirements. The formatting seems fine. It does seem strange to have Asp.Net, DotNetTools, IIS-Common, IIS-Setup, MSBuildLocator and dotnet-install.ps1 (.sh is not included). Do we typically include our own components in the TPN?

@dagood
Copy link
Member

dagood commented Sep 5, 2019

ASP.NET comes from CoreFX adding it here: https://github.com/dotnet/corefx/pull/38324/files, DotNetTools from https://github.com/dotnet/roslyn/pull/29403/files#diff-fa732c8fac311b142a7fa1c4f3fde1a9, and so on... can trace it back from the data in the third link. Everything added is in at least one TPN in some repo.

@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 30, 2020
@dagood dagood removed the Triaged label Jan 30, 2020
@jkotas jkotas removed this from the 3.0 milestone Mar 1, 2020
@dagood dagood removed their assignment Jul 1, 2020
@NikolaMilosavljevic NikolaMilosavljevic added this to the 5.0.0 milestone Jul 8, 2020
@NikolaMilosavljevic NikolaMilosavljevic changed the title Review and update THIRD-PARTY-NOTICES.TXT for 3.0 Review and update THIRD-PARTY-NOTICES.TXT Jul 8, 2020
@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic, please run the tool and create PR for review of contents and formatting.

@NikolaMilosavljevic
Copy link
Member

All repo owners should be included in review. @nakarnam

@dagood
Copy link
Member

dagood commented Aug 21, 2020

It doesn't look like I linked to my tooling anywhere--it's over here:
dagood/core-setup@bac3b0d...100d6dc (regen-tpn)

It needs to be ported into https://github.com/dotnet/runtime/tree/master/tools-local/tasks/installer.tasks to be maintainable.

@Anipik
Copy link
Contributor

Anipik commented Sep 28, 2020

@NikolaMilosavljevic any update on this one ?

@Anipik
Copy link
Contributor

Anipik commented Oct 3, 2020

Can close this after we merge #42989

@jeffschwMSFT
Copy link
Member

Closing via #42989

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.