Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Diagnostics.DiagnosticSource.Switches.Tests tests fail on Android/iOS/tvOS #37073

Closed
4 tasks
mdh1418 opened this issue May 27, 2020 · 3 comments · Fixed by #56737
Closed
4 tasks

System.Diagnostics.DiagnosticSource.Switches.Tests tests fail on Android/iOS/tvOS #37073

mdh1418 opened this issue May 27, 2020 · 3 comments · Fixed by #56737

Comments

@mdh1418
Copy link
Member

mdh1418 commented May 27, 2020

Based on Android x64, x86, arm64 runs on #50095

System.Diagnostics.DiagnosticSource.Switches.Tests

  • System.Diagnostics.Tests.ActivityTests.ActivityIdNonHierarchicalOverflow
    Assert.InRange() Failure\r\nRange: (55 - 56)\r\nActual: 27
  • System.Diagnostics.Tests.ActivityTests.IdFormat_ZeroTraceIdAndSpanIdWithHierarchicalFormat
    Assert.Equal() Failure\nExpected: Hierarchical\nActual: W3C
  • System.Diagnostics.Tests.ActivityTests.IdFormat_HierarchicalIsDefault
    Assert.Equal() Failure\nExpected: Hierarchical\nActual: W3C
  • System.Diagnostics.Tests.ActivityTests.IdGenerationInternalParent
    Expected: |3bb0aa728f97f001b74c999028c145ff.child1-1. || |3bb0aa728f97f001b74c999028c145ff.1.\nActual: 00-3bb0aa728f97f001b74c999028c145ff-005236cd8f819f69-00
System.Diagnostics.DiagnosticSource.Switches.Tests.dll   Failed: 4

Test collection for System.Diagnostics.Tests.ActivityTests
System.Diagnostics.Tests.ActivityTests.ActivityIdNonHierarchicalOverflow
    Assert.InRange() Failure\r\nRange:  (55 - 56)\r\nActual: 27
System.Diagnostics.Tests.ActivityTests.IdFormat_ZeroTraceIdAndSpanIdWithHierarchicalFormat
    Assert.Equal() Failure\nExpected: Hierarchical\nActual:   W3C
System.Diagnostics.Tests.ActivityTests.IdFormat_HierarchicalIsDefault
    Assert.Equal() Failure\nExpected: Hierarchical\nActual:   W3C
System.Diagnostics.Tests.ActivityTests.IdGenerationInternalParent
    Expected: |f7975b073fab84cb7f79edd32172a912.child1-1. || |f7975b073fab84cb7f79edd32172a912.1.\nActual: 00-f7975b073fab84cb7f79edd32172a912-97b1c565a0ff71e3-00

Update: Folded in #51376 as it also fails on iOS and tvOS with similar failures.

@ghost
Copy link

ghost commented May 27, 2020

Tagging subscribers to this area: @tommcdon, @krwq
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label May 27, 2020
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Jun 1, 2020
@tommcdon tommcdon added this to the 5.0 milestone Jun 8, 2020
@danmoseley danmoseley modified the milestones: 5.0.0, 6.0.0 Jun 16, 2020
@marek-safar marek-safar added untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner labels Jun 24, 2020
@noahfalk
Copy link
Member

@marek-safar - I notice this issue has been unaddressed for ~7 months. Is it tracking work you plan to do or can it be closed?

I ask because Tom's team has triage queries that include anything tagged System.Diagnostics but I don't think we have any actionable work here. We can update our queries with exclusions if needed. Thanks!

@marek-safar
Copy link
Contributor

I think it's worth updating your queries to exclude issues diagnostics team does not own. Essentially range of os-XXX architectures

@mdh1418 mdh1418 changed the title System.Diagnostics tests fail on Android System.Diagnostics.DiagnosticSource.Switches.Tests tests fail on Android Mar 31, 2021
@mdh1418 mdh1418 changed the title System.Diagnostics.DiagnosticSource.Switches.Tests tests fail on Android System.Diagnostics.DiagnosticSource.Switches.Tests tests fail on Android/iOS/tvOS Aug 2, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 2, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants