Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf -6%] System.Collections.CreateAddAndRemove<Int32>.SortedList #37801

Closed
DrewScoggins opened this issue Jun 12, 2020 · 3 comments
Closed

[Perf -6%] System.Collections.CreateAddAndRemove<Int32>.SortedList #37801

DrewScoggins opened this issue Jun 12, 2020 · 3 comments
Assignees
@layomia
Labels
arch-x64 area-System.Collections os-windows tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
5.0.0

Comments

@DrewScoggins
Copy link
Member

DrewScoggins commented Jun 12, 2020 •
edited
Loading

Run Information

Architecture x64
OS Windows 10.0.18362
Changes diff

Regressions in System.Collections.CreateAddAndRemove

Benchmark Baseline Test Test/Base Modality Baseline Outlier
SortedList 126.74 μs 134.04 μs 1.06 False

graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Collections.CreateAddAndRemove<Int32>*';

Histogram

System.Collections.CreateAddAndRemove.SortedList(Size: 512)

[124732.826 ; 127426.459) | @@@@@@@@@@@
[127426.459 ; 130051.050) | @@@@@@@@@@@@@@@@@@@@@@@@
[130051.050 ; 133750.686) | @@@@
[133750.686 ; 138403.785) | @@@@@@@@@@@@@@@@@@@
[138403.785 ; 143874.037) | @

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@DrewScoggins DrewScoggins added the tenet-performance-benchmarks Issue from performance benchmark label Jun 12, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Collections untriaged New issue has not been triaged by the area owner labels Jun 12, 2020
@ghost
Copy link

ghost commented Jun 12, 2020

Tagging subscribers to this area: @eiriktsarpalis
Notify danmosemsft if you want to be subscribed.

@DrewScoggins
Copy link
Member Author

@adamsitnik

@eiriktsarpalis eiriktsarpalis added this to the 5.0.0 milestone Jun 24, 2020
@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Jun 24, 2020
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark os-windows arch-x64 and removed tenet-performance-benchmarks Issue from performance benchmark labels Jul 7, 2020
@danmoseley
Copy link
Member

Duplicate of #39112

@danmoseley danmoseley marked this as a duplicate of #39112 Aug 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
arch-x64 area-System.Collections os-windows tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
5 participants
@eiriktsarpalis @danmoseley @DrewScoggins @layomia @Dotnet-GitSync-Bot