-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf -152%] System.IO.Tests.Perf_Path.GetRandomFileName #39122
Comments
@DrewScoggins the diff link does not work. Can you please share the diff bracketing this jump? |
Yeah, there seems to be a bug here if the points you are trying to diff go across the switch to the runtime repo. You can use the report to generate a tight diff, again as long as the comparison you are trying to do is after the switch to the runtime repo. To do this
By following these steps I generated this link 4a4e347...d0889f1, which should be able to give you the bounds that you want. Sorry again for the bug in the diff link, I will fix that to link to the installer repo which is what we are actually generating the hashes for, but hopefully this helps you track down diffs going forward 😄 |
Thanks for the info.
I don't think that's the diff we want for the microbenchmarks. The issues sounds have diff across runtime repo commits surely? |
I can't repro this locally (on Ubuntu 18.04). I've run the benchmark multiple times, and each time I get results like this:
|
Duplicate of #39114 . Both NewGuid and GetRandomFileName use the same underlying OS random number generator. |
Run Information
Regressions in System.IO.Tests.Perf_Path
Related Issue on x86 Windows
[Perf -15%] System.IO.Tests.Perf_Path.GetPathRoot
Historical Data in Reporting System
Repro
Histogram
System.IO.Tests.Perf_Path.GetRandomFileName
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: