Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Commit appears multiple times in strings libcoreclr.so output #39456

Closed
echesakov opened this issue Jul 16, 2020 · 9 comments · Fixed by #41711
Closed

@Commit appears multiple times in strings libcoreclr.so output #39456

echesakov opened this issue Jul 16, 2020 · 9 comments · Fixed by #41711
Labels
area-Infrastructure-coreclr os-linux Linux OS (any supported distro)
Milestone

Comments

@echesakov
Copy link
Contributor

Noticed this while working on a bug, @Commit string appears multiple times during strings libcoreclr.so | grep "@Commit" command that suggest version.c was included multiple times. While this behavior was reproduced on linux-arm, it is probably not specific to the architecture.

robox@DDNANO3:~/echesako/runtime/artifacts/bin/testhost/net5.0-Linux-Release-arm/shared/Microsoft.NETCore.App/5.0.0$ strings libcoreclr.so | grep "@Commit"
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281
@(#)Version 42.42.42.42424 @Commit: e708795013a1bcca337daeee09732d4d5fad6281

cc @janvorli @VSadov

@echesakov echesakov added the os-linux Linux OS (any supported distro) label Jul 16, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 16, 2020
@jkotas jkotas added this to the 5.0.0 milestone Jul 17, 2020
@jashook jashook removed the untriaged New issue has not been triaged by the area owner label Aug 3, 2020
@ViktorHofer
Copy link
Member

We don't believe this is crucial to fix for 5.0. Moving to 6.0.

@ViktorHofer
Copy link
Member

@janvorli @jkotas are you fine with moving this to 6.0?

@jkotas
Copy link
Member

jkotas commented Sep 1, 2020

This version string is frequently used to identify the exact version of CoreCLR on the system. In best cast, this will just look ugly. In worst case, it is going to break ad-hoc tooling that looks for this string.

@jkotas
Copy link
Member

jkotas commented Sep 1, 2020

I think this meets the breaking change point in the ask mode bar.

@jkotas jkotas modified the milestones: 6.0.0, 5.0.0 Sep 1, 2020
@ViktorHofer
Copy link
Member

Works for me. Still we need someone to drive this. @jkotas do you have cycles to look into?

@jkotas
Copy link
Member

jkotas commented Sep 1, 2020

I believe @janvorli has been looking into this.

@janvorli
Copy link
Member

janvorli commented Sep 1, 2020

Correct, I am planning to fix that today or tomorrow the latest.

@ViktorHofer
Copy link
Member

Thanks Jan

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-coreclr os-linux Linux OS (any supported distro)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants