Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.TestFunctionApply failed on CI (wasm mono subset) #40112

Closed
maryamariyan opened this issue Jul 29, 2020 · 12 comments
Closed

System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.TestFunctionApply failed on CI (wasm mono subset) #40112

maryamariyan opened this issue Jul 29, 2020 · 12 comments
Assignees
@kg
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Milestone
6.0.0

Comments

@maryamariyan
Copy link
Member

Some wasm test failures on the PR #39825:
https://dev.azure.com/dnceng/public/_build/results?buildId=749999&view=ms.vss-test-web.build-test-results-tab

System.Linq.Expressions.Tests
System.Runtime.InteropServices.JavaScript.Tests

e.g.: System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.TestFunctionApply

Error message
System.Runtime.InteropServices.JavaScript.JSException : Error: System.NullReferenceException: Object reference not set to an instance of an object.\n   at System.Runtime.InteropServices.JavaScript.Tests.HelperMarshal.CreateFunctionApply()

Stack trace
   at Interop.Runtime.InvokeJS(String str)
   at System.Runtime.InteropServices.JavaScript.Runtime.InvokeJS(String str)
   at System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.TestFunctionApply()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
@maryamariyan maryamariyan added the arch-wasm WebAssembly architecture label Jul 29, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Runtime.InteropServices untriaged New issue has not been triaged by the area owner labels Jul 29, 2020
@MaximLipnin
Copy link
Contributor

It seems to be flaky - I got the failure 4 times out of 10 locally.

@MaximLipnin
Copy link
Contributor

Besides that, there can be something like:

  dbug: test[0]
        [FAIL] System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTests.FunctionMath
  dbug: test[0]
        Assert.NotNull() Failure
  dbug: test[0]
           at System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTests.FunctionMath()
  dbug: test[0]
           at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

@MaximLipnin
Copy link
Contributor

The failing tests will be disabled in #40139

@akoeplinger akoeplinger mentioned this issue Jul 30, 2020
Merged
@marek-safar marek-safar added this to the 5.0.0 milestone Jul 31, 2020
@lewing
Copy link
Member

lewing commented Jul 31, 2020

This failure seems to go away if you pass --disable-on-demand-gc so it is likely related to the on-demand GC, either a bug there or ref counting/pinning issues in the bindings.

@lewing
Copy link
Member

lewing commented Aug 1, 2020

cc @vargaz

@lewing lewing mentioned this issue Aug 3, 2020
Merged
@lewing lewing assigned kg and unassigned kjpou1 Aug 3, 2020
@kjpou1 kjpou1 mentioned this issue Aug 20, 2020
Merged
@marek-safar marek-safar changed the title [WASM]: System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.TestFunctionApply failed on CI (wasm mono subset) System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.TestFunctionApply failed on CI (wasm mono subset) Sep 3, 2020
@marek-safar
Copy link
Contributor

@kg @lewing where are we on this one?

@kg
Copy link
Member

kg commented Sep 3, 2020

We're disabling on demand GC in the release, and I've been working on binding fixes that should fix this for .NET 6. I don't know if the current set of fixes is sufficient yet

@marek-safar marek-safar modified the milestones: 5.0.0, 6.0.0 Sep 3, 2020
@lewing
Copy link
Member

lewing commented Sep 17, 2020

@kg is this still failing for net5.0?

@kg
Copy link
Member

kg commented Sep 17, 2020

I never successfully reproduced this bug locally to begin with, so I don't know.

@lewing
Copy link
Member

lewing commented Sep 17, 2020

Ok, I'll take a look. I was able to reproduce it in the past.

@lewing lewing self-assigned this Sep 17, 2020
@MaximLipnin
Copy link
Contributor

System.Runtime.InteropServices.JavaScript.Tests.MarshalTests.MarshalTypedArrayByte also fails with NRE - it has the most stable local repro.

@MaximLipnin MaximLipnin mentioned this issue Sep 22, 2020
Merged
@lewing lewing removed their assignment Sep 26, 2020
@lewing
Copy link
Member

lewing commented Sep 26, 2020

@kg was able to reproduce locally

@kg kg mentioned this issue Oct 16, 2020
Merged
@lewing lewing closed this as completed Jun 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kg kg

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
7 participants
@lewing @kg @marek-safar @kjpou1 @MaximLipnin @maryamariyan @Dotnet-GitSync-Bot