Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OdbcConnection.ServerVersion may return null but docs says it will throw or return "" instead #44289

Open
krwq opened this issue Nov 5, 2020 · 3 comments

Comments

@krwq
Copy link
Member

krwq commented Nov 5, 2020

See docs: https://docs.microsoft.com/en-us/dotnet/api/system.data.odbc.odbcconnection.serverversion?view=dotnet-plat-ext-3.1

but implementation OdbcConnectionOpen.ServerVersion will return null in some cases.

Either docs or implementation should be fixed here.

Found when applying nullable annotations

@ghost
Copy link

ghost commented Nov 5, 2020

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Nov 5, 2020
@roji
Copy link
Member

roji commented Nov 5, 2020

@krwq
Copy link
Member Author

krwq commented Nov 5, 2020

Yes, this is based on your comment, I'll be removing TODO-NULLABLEs or replacing them with issues or fixing in a PR soon

@ajcvickers ajcvickers added this to the Future milestone Jul 13, 2021
@ajcvickers ajcvickers removed the untriaged New issue has not been triaged by the area owner label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants