-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change in ResourceSet class #44483
Comments
Revert in #44482 |
Tagging subscribers to this area: @tarekgh, @buyaa-n, @krwq, @jeffhandley Issue meta data
|
@sebastienros what is the failure? |
I left all the details on the PR. To summarize |
@marek-safar here is @sebastienros comment regarding the failure #44104 (comment) |
I see you are casting object to underlying type. That needs to be fixed on runtime side. |
@marek-safar just to make sure you saw @jkotas PR reverting your change which broke this scenario #44482 |
Yep, let's revert this to unblock them. I'll fix that in follow up PR (revert) |
This PR #44104 introduces a breaking change that is only experienced at runtime.
ResourceSet
implementsIEnumerable
and ASP.NET Core is using the contract.At least there, but other tests break so it might not be isolated.
https://github.com/dotnet/aspnetcore/blob/master/src/Localization/Localization/src/Internal/ResourceManagerStringProvider.cs#L75
While we could react to this change, it doesn't seem that this change of behavior was intentional.
The text was updated successfully, but these errors were encountered: