Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][websocket][tests] WebSocket Abort tests multiple failures #45674

Closed
kjpou1 opened this issue Dec 7, 2020 · 1 comment · Fixed by #47906
Closed

[browser][websocket][tests] WebSocket Abort tests multiple failures #45674

kjpou1 opened this issue Dec 7, 2020 · 1 comment · Fixed by #47906
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Net
Milestone

Comments

@kjpou1
Copy link
Contributor

kjpou1 commented Dec 7, 2020

There are multiple failures with the Abort tests causing some tests to:

  • Never end

  • Multiple GC calls that end in running out of memory.

  • Some failures are expected to fail with specific WebSocketError codes:

Error codes that are not correct tend to be when websockets tests are looking for specific error codes and messages when the browser returns NativeError and the websocket native error code instead.

failed: WebSocket is closed before the connection is established.

These need to be marked correctly and or caught and wrapped correctly.

Assert.Equal() Failure
  info: Expected: Aborted
  info: Actual:   Closed

Other issues stem from the Abort being called before the connection. This depends on the modifications from PR #44722 being accepted.

Fixes for these should also fix some, note not all, of the memory runtime errors as per issue: #45586

Associate PR's: #44666 and #45470

@kjpou1 kjpou1 added arch-wasm WebAssembly architecture area-System.Net labels Dec 7, 2020
@kjpou1 kjpou1 self-assigned this Dec 7, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 7, 2020
@ghost
Copy link

ghost commented Dec 7, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

There are multiple failures with the Abort tests causing some tests to:

  • Never end

  • Multiple GC calls that end in running out of memory.

  • Some failures are expected to fail with specific WebSocketError codes:

Error codes that are not correct tend to be when websockets are looking for specific error codes and messages when the browser returns NativeError and the websocket native error code instead instead.

These need to be marked correctly and or wrapped caught and wrapped correctly.

Other issues stem from the Abort being called before the connection. This depends on the modifications from PR #44722 being accepted.

Fixes for these should also fix some of the memory runtime errors as per issue: #45586

Author: kjpou1
Assignees: kjpou1
Labels:

arch-wasm, area-System.Net

Milestone: -

@kjpou1 kjpou1 removed the untriaged New issue has not been triaged by the area owner label Dec 7, 2020
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 9, 2020
@kjpou1 kjpou1 added this to the 6.0.0 milestone Jan 5, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net
Projects
None yet
2 participants