Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event source should have a good trimming experience #46231

Closed
5 tasks done
agocke opened this issue Dec 18, 2020 · 3 comments
Closed
5 tasks done

Event source should have a good trimming experience #46231

agocke opened this issue Dec 18, 2020 · 3 comments
Assignees
@LakshanF
Labels
area-Tracing-coreclr enhancement Product code improvement that does NOT require public API changes/additions linkable-framework Issues associated with delivering a linker friendly framework
Milestone
6.0.0

Comments

@agocke
Copy link
Member

agocke commented Dec 18, 2020 •
edited
Loading

Goals

  • Event source should not produce warnings by default
  • Event source should only produce actionable warnings if tracing is enabled
  • Event source is annotated and doesn't produce interior warnings

Work

  • Finish event source feature switch
  • If diagnostic tracing is attached, produce diagnostic about tracing being disabled
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Tracing-coreclr untriaged New issue has not been triaged by the area owner labels Dec 18, 2020
@agocke agocke added linkable-framework Issues associated with delivering a linker friendly framework and removed untriaged New issue has not been triaged by the area owner labels Dec 18, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF
See info in area-owners.md if you want to be subscribed.

Issue Details

Goals

  • Event source should not produce warnings by default
  • Event source should only produce actionable warnings if tracing is enabled

Work

  • Finish event source feature switch
  • If diagnostic tracing is attached, produce diagnostic about tracing being disabled
Author: agocke
Assignees: -
Labels:

area-Tracing-coreclr, linkable-framework
Milestone: -

@eerhardt
Copy link
Member

Event source should not produce warnings by default

This work should take care of the 2nd row in #45623: System.Private.CoreLib - EventSource.

@tommcdon tommcdon added the enhancement Product code improvement that does NOT require public API changes/additions label Dec 28, 2020
@tommcdon tommcdon added this to the 6.0.0 milestone Feb 18, 2021
@agocke
Copy link
Member Author

agocke commented May 17, 2021

We think EventSource types in the framework are now trim-compatible, and the appropriate warnings are produced for other EventSource providers. There's no more trimming work planned at the moment.

@agocke agocke closed this as completed May 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LakshanF LakshanF

Labels
area-Tracing-coreclr enhancement Product code improvement that does NOT require public API changes/additions linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
5 participants
@agocke @LakshanF @eerhardt @tommcdon @Dotnet-GitSync-Bot