-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] InvariantGlobalization=true no longer removes all icu references #49499
Comments
Tagging subscribers to this area: @tarekgh, @safern Issue DetailsWe're seeing failures in CI during runtime linking where the linker considers the icu symbols still reachable when they shouldn't be. We need to figure out how this is happening.
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsWe're seeing failures in CI during runtime linking where the linker considers the icu symbols still reachable when they shouldn't be. We need to figure out how this is happening.
|
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer Issue DetailsWe're seeing failures in CI during runtime linking where the linker considers the icu symbols still reachable when they shouldn't be. We need to figure out how this is happening.
|
@radical we should add symbol checks to the build tests so that we catch this case in a more specific way |
Related discussion on #48847 (comment) |
What caused the crash in #47301 was what we had originally expected: was not able to be parsed by the linker, which led to the following line to be called:
|
This is not true. I added only two methods in this PR. The rest was there. Looks there is something more you need to investigate. The change I did in the icu shim is I added a parameter to one of the macros. I am not sure if this can make any difference. |
@tarekgh After looking over it again, it seems like the undefined symbols are the ones with the added parameter. I will try again from a clean build. |
@tqiu8 - are you working on this issue? If so, can it be assigned to you? |
After #50266 (and others) this is resolved. |
We're seeing failures in CI during runtime linking where the native linker considers the icu symbols still reachable when they shouldn't be. The native symbols are on the other side of a pinvoke are typically rooted by pinvoke-table.h which is generated as part of the runtime relinking by scanning the managed assemblies looking for attributes.
Current theory is that the build is picking up the wrong header under as yet unknown conditions.
Aside from the above issue, any of the AOT tests using AggressiveTrimming should verify that those attributes are preserved.
The text was updated successfully, but these errors were encountered: