Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][build] EMSDK_PATH being overridden #49809

Closed
kjpou1 opened this issue Mar 18, 2021 · 2 comments · Fixed by #49810
Closed

[wasm][build] EMSDK_PATH being overridden #49809

kjpou1 opened this issue Mar 18, 2021 · 2 comments · Fixed by #49810
Assignees
@kjpou1
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone
Future

Comments

@kjpou1
Copy link
Contributor

kjpou1 commented Mar 18, 2021 •
edited
Loading

Even if the EMSDK_PATH variable is set the build is overriding the variable and resetting it to the in tree provision directory
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 18, 2021
@kjpou1 kjpou1 self-assigned this Mar 18, 2021
@kjpou1 kjpou1 added arch-wasm WebAssembly architecture area-Build-mono labels Mar 18, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

If the EMSDK_PATH variable is set the build is overriding the variable and resetting it to the in tree provision directory

Author: kjpou1
Assignees: kjpou1
Labels:

arch-wasm, area-Build-mono, untriaged
Milestone: -

@kjpou1 kjpou1 removed the untriaged New issue has not been triaged by the area owner label Mar 18, 2021
@kjpou1 kjpou1 added this to the Future milestone Mar 18, 2021
@kjpou1 kjpou1 mentioned this issue Mar 18, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 18, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 18, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kjpou1 kjpou1

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

[browser][build] Only override and set EMSDK_PATH if it is not already set.
1 participant
@kjpou1