Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Build improvements ideas #53394

Closed
1 of 3 tasks
radical opened this issue May 28, 2021 · 6 comments
Closed
1 of 3 tasks

[wasm] Build improvements ideas #53394

radical opened this issue May 28, 2021 · 6 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone

Comments

@radical
Copy link
Member

radical commented May 28, 2021

Based on @lewing's review of #52941

  • Can runtime packs have a props file that would get imported automatically?
  • Consider moving some bits of Emscripten property checks and setup to the WorkloadManifest package.
  • For the link step we pass -s TOTAL_MEMORY=536870912 - should this become a property?
@radical radical added the arch-wasm WebAssembly architecture label May 28, 2021
@ghost
Copy link

ghost commented May 28, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on @lewing's review of #52941

  • Can runtime packs have a props file that would get imported automatically?
  • Consider moving some bits of Emscripten properties setting to the nugets
  • For the link step we pass -s TOTAL_MEMORY=536870912 - should this become a property?
Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 28, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label May 28, 2021
@lewing lewing added this to the 6.0.0 milestone May 28, 2021
@radical
Copy link
Member Author

radical commented May 28, 2021

@akoeplinger any idea about Can runtime packs have a props file that would get imported automatically?

I couldn't find anything on this, and trying it locally it didn't seem to work.

@ghost
Copy link

ghost commented May 28, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on @lewing's review of #52941

  • Can runtime packs have a props file that would get imported automatically?
  • Consider moving some bits of Emscripten property checks and setup to the WorkloadManifest package.
  • For the link step we pass -s TOTAL_MEMORY=536870912 - should this become a property?
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: 6.0.0

@akoeplinger
Copy link
Member

@radical I'm not aware of anything that imports .props for runtime packs, they're treated specially by the .NET SDK and not really like a normal nuget package. We could come up with some logic that we put into the .NET SDK though.

@radical
Copy link
Member Author

radical commented Aug 1, 2021

Merged the todo items with #50287 .

@radical radical closed this as completed Aug 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

No branches or pull requests

4 participants