Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][websocket] System.Net.WebSockets.Client.Tests should throw #54153

Open
pavelsavara opened this issue Jun 14, 2021 · 3 comments
Open

[wasm][websocket] System.Net.WebSockets.Client.Tests should throw #54153

pavelsavara opened this issue Jun 14, 2021 · 3 comments
Labels
arch-wasm WebAssembly architecture area-System.Net.Http disabled-test The test is disabled in source code against the issue
Milestone
Future

Comments

@pavelsavara
Copy link
Member

pavelsavara commented Jun 14, 2021 •
edited
Loading

1

in System.Net.WebSockets.Client.Tests.CloseTest.CloseAsync_CancelableEvenWhenPendingReceive_Throws in Browser on windows.

[FAIL] System.Net.WebSockets.Client.Tests.CloseTest.CloseAsync_CancelableEvenWhenPendingReceive_Throws
Assert.Throws() Failure
Expected: typeof(System.OperationCanceledException)
Actual:   (No exception was thrown)
   at System.Net.WebSockets.Client.Tests.CloseTest.<>c__DisplayClass14_0.<<CloseAsync_CancelableEvenWhenPendingReceive_Throws>b__0>d.MoveNext() in C:\Dev\runtime\src\libraries\System.Net.WebSockets.Client\tests\CloseTest.cs:line 394
--- End of stack trace from previous location ---
   at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in C:\Dev\runtime\src\libraries\Common\tests\System\Threading\Tasks\TaskTimeoutExtensions.cs:line 63
   at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in C:\Dev\runtime\src\libraries\Common\tests\System\Threading\Tasks\TaskTimeoutExtensions.cs:line 82
   at System.Net.Test.Common.LoopbackServer.<>c__DisplayClass16_0.<<CreateClientAndServerAsync>b__0>d.MoveNext() in C:\Dev\runtime\src\libraries\Common\tests\System\Net\Http\LoopbackServer.cs:line 123
--- End of stack trace from previous location ---
   at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options) in C:\Dev\runtime\src\libraries\Common\tests\System\Net\Http\LoopbackServer.cs:line 105
   at System.Net.WebSockets.Client.Tests.CloseTest.CloseAsync_CancelableEvenWhenPendingReceive_Throws() in C:\Dev\runtime\src\libraries\System.Net.WebSockets.Client\tests\CloseTest.cs:line 382

2

In System.Net.WebSockets.Client.Tests.MemorySendReceiveTest.SendReceive_ConnectionClosedPrematurely_ReceiveAsyncFailsAndWebSocketStateUpdated

Failure
Expected: typeof(System.Net.WebSockets.WebSocketException)
Actual:   (No exception was thrown)
   at System.Net.WebSockets.Client.Tests.SendReceiveTest.<>c__DisplayClass11_0.<<SendReceive_ConnectionClosedPrematurely_ReceiveAsyncFailsAndWebSocketStateUpdated>b__0>d.MoveNext() in C:\Dev\runtime\src\libraries\System.Net.WebSockets.Client\tests\SendReceiveTest.cs:line 428
--- End of stack trace from previous location ---
   at System.Net.WebSockets.Client.Tests.SendReceiveTest.<>c__DisplayClass11_0.<<SendReceive_ConnectionClosedPrematurely_ReceiveAsyncFailsAndWebSocketStateUpdated>b__1>d.MoveNext() in C:\Dev\runtime\src\libraries\System.Net.WebSockets.Client\tests\SendReceiveTest.cs:line 455
--- End of stack trace from previous location ---
   at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options) in C:\Dev\runtime\src\libraries\Common\tests\System\Net\Http\LoopbackServer.cs:line 105
   at System.Net.WebSockets.Client.Tests.SendReceiveTest.SendReceive_ConnectionClosedPrematurely_ReceiveAsyncFailsAndWebSocketStateUpdated() in C:\Dev\runtime\src\libraries\System.Net.WebSockets.Client\tests\SendReceiveTest.cs:line 451
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Net.Http labels Jun 14, 2021
@ghost
Copy link

ghost commented Jun 14, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

in System.Net.WebSockets.Client.Tests.CloseTest.CloseAsync_CancelableEvenWhenPendingReceive_Throws in Browser on windows.

[FAIL] System.Net.WebSockets.Client.Tests.CloseTest.CloseAsync_CancelableEvenWhenPendingReceive_Throws
Assert.Throws() Failure
Expected: typeof(System.OperationCanceledException)
Actual:   (No exception was thrown)
   at System.Net.WebSockets.Client.Tests.CloseTest.<>c__DisplayClass14_0.<<CloseAsync_CancelableEvenWhenPendingReceive_Throws>b__0>d.MoveNext() in C:\Dev\runtime\src\libraries\System.Net.WebSockets.Client\tests\CloseTest.cs:line 394
--- End of stack trace from previous location ---
   at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in C:\Dev\runtime\src\libraries\Common\tests\System\Threading\Tasks\TaskTimeoutExtensions.cs:line 63
   at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in C:\Dev\runtime\src\libraries\Common\tests\System\Threading\Tasks\TaskTimeoutExtensions.cs:line 82
   at System.Net.Test.Common.LoopbackServer.<>c__DisplayClass16_0.<<CreateClientAndServerAsync>b__0>d.MoveNext() in C:\Dev\runtime\src\libraries\Common\tests\System\Net\Http\LoopbackServer.cs:line 123
--- End of stack trace from previous location ---
   at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options) in C:\Dev\runtime\src\libraries\Common\tests\System\Net\Http\LoopbackServer.cs:line 105
   at System.Net.WebSockets.Client.Tests.CloseTest.CloseAsync_CancelableEvenWhenPendingReceive_Throws() in C:\Dev\runtime\src\libraries\System.Net.WebSockets.Client\tests\CloseTest.cs:line 382
Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Net.Http
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 14, 2021
@pavelsavara pavelsavara changed the title [wasm][websocket] CloseAsync_CancelableEvenWhenPendingReceive_Throws [wasm][websocket] System.Net.WebSockets.Client.Tests should throw Jun 14, 2021
@pavelsavara pavelsavara mentioned this issue Jun 16, 2021
Merged
@lewing lewing added this to the 7.0.0 milestone Jun 17, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jun 17, 2021
@lewing
Copy link
Member

lewing commented Jun 17, 2021

This is a definite difference in behavior but it isn't near critical path for NET6

@pavelsavara pavelsavara modified the milestones: 7.0.0, Future Jul 26, 2022
@pavelsavara
Copy link
Member Author

I confirmed this still happens with latest code for Net7, moving to Future.

@MihaZupan MihaZupan added the disabled-test The test is disabled in source code against the issue label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Net.Http disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@lewing @pavelsavara @MihaZupan