Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rosetta x64 translation fools arch detection in installers #59370

Closed
ericstj opened this issue Sep 20, 2021 · 3 comments
Closed

Rosetta x64 translation fools arch detection in installers #59370

ericstj opened this issue Sep 20, 2021 · 3 comments
Labels
area-Infrastructure-installer blocking-release
Milestone
6.0.0

Comments

@ericstj
Copy link
Member

ericstj commented Sep 20, 2021

Initial thread: #59295 (comment)

When running on M1 mac, if the installer is launched from a rosetta terminal it runs under x64 translation.

This causes the installer to falsely identify the machine as x64.

We should avoid this if we can using sysctl.proc_translated
https://developer.apple.com/documentation/apple-silicon/about-the-rosetta-translation-environment

We need to leverage this here in the host's postinstall script, as well as in the bundle authoring in arcade and installer. cc @sfoslund
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Infrastructure-installer untriaged New issue has not been triaged by the area owner labels Sep 20, 2021
@ericstj ericstj added this to the 6.0.0 milestone Sep 20, 2021
@ericstj ericstj mentioned this issue Sep 20, 2021
Merged
@ericstj
Copy link
Member Author

ericstj commented Sep 20, 2021

Here's a gist that shows modified detection and logged results: https://gist.github.com/ericstj/12c046c2142cc6134ca783324d59d4a6

@ericstj ericstj added blocking-release and removed untriaged New issue has not been triaged by the area owner labels Sep 20, 2021
@ericstj
Copy link
Member Author

ericstj commented Sep 22, 2021

Fixed in dotnet/arcade#7919, dotnet/arcade#7918

@ericstj ericstj closed this as completed Sep 22, 2021
@ericstj
Copy link
Member Author

ericstj commented Sep 22, 2021 •
edited
Loading

Also 12183cb #59485 (for mac postinstall)

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure-installer blocking-release
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@ericstj