Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failure in the test System.IO.Tests.FileStream_DeleteOnClose.OpenOrCreate_DeleteOnClose_UsableAsMutex #60147

Closed
tarekgh opened this issue Oct 7, 2021 · 7 comments · Fixed by #60149
Closed

CI failure in the test System.IO.Tests.FileStream_DeleteOnClose.OpenOrCreate_DeleteOnClose_UsableAsMutex #60147

tarekgh opened this issue Oct 7, 2021 · 7 comments · Fixed by #60149
Labels
area-System.IO needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration test-bug Problem in test source code (most likely)
Milestone
Future

Comments

@tarekgh
Copy link
Member

tarekgh commented Oct 7, 2021 •
edited by runfoapp bot
Loading

Description

Sorry if this is reported before but I couldn't find it.

https://dev.azure.com/dnceng/public/_build/results?buildId=1408804&view=logs&j=9d8498d2-c5b7-54d8-6df7-a2ce7e14e68c&t=34b459a3-e64e-5ccc-0adc-77ebca2601a8&l=76

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-60140-merge-4e7f21a19bc8454287/System.IO.FileSystem.Tests/1/console.9ded26c7.log?sv=2019-07-07&se=2021-10-27T21%3A23%3A04Z&sr=c&sp=rl&sig=RgndSl%2BsYm6%2BKHG%2BoPaY29nuRCwkAjsZ04p3ZJTxQ58%3D

    System.IO.Tests.FileStream_DeleteOnClose.OpenOrCreate_DeleteOnClose_UsableAsMutex [FAIL]
      Test cancelled
      Expected: False
      Actual:   True
      Stack Trace:
        /_/src/libraries/System.IO.FileSystem/tests/FileStream/DeleteOnClose.cs(77,0): at System.IO.Tests.FileStream_DeleteOnClose.OpenOrCreate_DeleteOnClose_UsableAsMutex()
        --- End of stack trace from previous location ---

Reproduction Steps

It is CI failure

Expected behavior

System.IO.Tests.FileStream_DeleteOnClose.OpenOrCreate_DeleteOnClose_UsableAsMutex test succeed in CI runs

Actual behavior

Test Failing

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Runfo Tracking Issue: System.IO.Tests.FileStream_DeleteOnClose.OpenOrCreate_DeleteOnClose_UsableAsMutex

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1418769 runtime PR 60357 net7.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py
1418060 runtime PR 58434 net7.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py
1417939 runtime PR 60075 net7.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py
1417474 runtime PR 57434 net7.0-Linux-Debug-x64-Mono_release-(Centos.7.Amd64.Open)Ubuntu.1604.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-7-mlnet-helix-20210714125435-dde38af console.log runclient.py
1416382 runtime PR 58674 net7.0-Linux-Debug-x64-mono_interpreter_release-(Debian.10.Amd64.Open)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-10-helix-amd64-20210304164434-56c6673 console.log runclient.py
1415888 runtime PR 58932 net7.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py
1412266 runtime PR 59672 net7.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py
1411894 runtime PR 60216 net7.0-windows-Debug-x86-CoreCLR_checked-Windows.10.Amd64.Open console.log runclient.py
1409599 runtime Rolling net7.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py
1408011 runtime PR 59930 net7.0-windows-Debug-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
4 10 10
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.IO untriaged New issue has not been triaged by the area owner labels Oct 7, 2021
@ghost
Copy link

ghost commented Oct 7, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Sorry if this is reported before but I couldn't find it.

https://dev.azure.com/dnceng/public/_build/results?buildId=1408804&view=logs&j=9d8498d2-c5b7-54d8-6df7-a2ce7e14e68c&t=34b459a3-e64e-5ccc-0adc-77ebca2601a8&l=76

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-60140-merge-4e7f21a19bc8454287/System.IO.FileSystem.Tests/1/console.9ded26c7.log?sv=2019-07-07&se=2021-10-27T21%3A23%3A04Z&sr=c&sp=rl&sig=RgndSl%2BsYm6%2BKHG%2BoPaY29nuRCwkAjsZ04p3ZJTxQ58%3D

    System.IO.Tests.FileStream_DeleteOnClose.OpenOrCreate_DeleteOnClose_UsableAsMutex [FAIL]
      Test cancelled
      Expected: False
      Actual:   True
      Stack Trace:
        /_/src/libraries/System.IO.FileSystem/tests/FileStream/DeleteOnClose.cs(77,0): at System.IO.Tests.FileStream_DeleteOnClose.OpenOrCreate_DeleteOnClose_UsableAsMutex()
        --- End of stack trace from previous location ---

Reproduction Steps

It is CI failure

Expected behavior

System.IO.Tests.FileStream_DeleteOnClose.OpenOrCreate_DeleteOnClose_UsableAsMutex test succeed in CI runs

Actual behavior

Test Failing

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author: tarekgh
Assignees: -
Labels:

area-System.IO, untriaged
Milestone: -

@tarekgh tarekgh mentioned this issue Oct 7, 2021
Merged
@danmoseley
Copy link
Member

Seems outcome of #55327 ? @tmds @carlossanlop

@danmoseley
Copy link
Member

This is Windows 7, if it matters: "Console log: 'System.IO.FileSystem.Tests' from job 4e7f21a1-9bc8-4542-872a-418edd6d138c workitem f8066dad-180e-4fdc-befd-f4ae375379fa (windows.7.amd64.open.rt) executed on machine a0019WJ"

@carlossanlop
Copy link
Member

The code fix in PR #55327 was intended for Unix specifically. The unit test is brand new, and it should be limited to only Unix platforms. @tmds, correct me if I'm wrong, but is the test supposed to run and pass on Windows as well?

To help unblock, I'll submit a PR to limit the test to run only on Unix. @tmds if the test is supposed to run on Windows too, please let me know, and we can discuss the appropriate code fix.

cc @adamsitnik @jozkee

@carlossanlop carlossanlop mentioned this issue Oct 7, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 7, 2021
@jozkee
Copy link
Member

jozkee commented Oct 8, 2021

@carlossanlop I think PR #55327 is trying to emulate Windows behavior, therefore I think the test should run for both platforms.

@tmds
Copy link
Member

tmds commented Oct 8, 2021

Yes, it emulates windows behavior and should pass there.

Test cancelled

I should have made this say "Test timed out".

In the test, 50 threads try to exclusively open a file. The test passes when the file got opened 1000 times, or when it takes longer than 30 seconds. It's a concurrency stress test.

I'm fine if we skip this on Windows because it is validating a specific part of the Unix implementation (to be compatible with Windows).

Alternatively, we can increase the timeout, and maybe move it to outerloop if it is consider to take too much time.

@danmoseley
Copy link
Member

Time taken is mostly relevant for local test runs. If a test takes a couple mins in the cloud it’s not noticeable. Perhaps this is a case where the test is normally fast but we run it so often in the cloud that we will cover the distribution. If that’s the problem then just increasing the timeout is normally what we do.

@runfoapp runfoapp bot closed this as completed Oct 8, 2021
@krwq krwq reopened this Oct 8, 2021
@jeffhandley jeffhandley added needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration test-bug Problem in test source code (most likely) and removed untriaged New issue has not been triaged by the area owner labels Oct 9, 2021
@jeffhandley jeffhandley added this to the Future milestone Oct 9, 2021
@jeffhandley jeffhandley mentioned this issue Oct 9, 2021
Closed
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 14, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.IO needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Test fix: FileStream DeleteOnClose run on OuterLoop with longer timeout carlossanlop/runtime
7 participants
@krwq @tmds @jeffhandley @carlossanlop @danmoseley @tarekgh @jozkee