Equivalent of DefaultContractResolver.CreateProperties override in System.Text.Json

[RonenGlants]

I used ContractResolver.CreateProperties override option to mark using reflection all properties including private ones to be serialized and deserialized using the following code:

using System;
using Xunit;
using Newtonsoft.Json;
using Newtonsoft.Json.Serialization;
using System.Collections.Generic;
using System.Reflection;
using System.Linq;

namespace SomeNamespace
{
    public class NewtonesoftSample
    {
        private JsonSerializerSettings _settings;

        public NewtonesoftSample()
        {
            _settings = new JsonSerializerSettings() { ContractResolver = new MyContractResolver() };
        }

        public class MyContractResolver : Newtonsoft.Json.Serialization.DefaultContractResolver
        {
            protected override IList<JsonProperty> CreateProperties(Type type, MemberSerialization memberSerialization)
            {
                var props = type.GetProperties(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)
                                .Select(property => base.CreateProperty(property, memberSerialization))
                                .Union(type.GetFields(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)
                                .Select(field => base.CreateProperty(field, memberSerialization)))
                                .ToList();
                props.ForEach(p => { p.Writable = true; p.Readable = true; });
                return props;
            }
        }

        [Fact]
        public void Validate_SampleObjectWithPrivatePropWithNoConstructor()
        {
            var val = new SampleObjectWithPrivatePropWithNoConstructor();
            val.Set(val: 2);
            var serializedVal = JsonConvert.SerializeObject(val, _settings);
            var deserializedVal = JsonConvert.DeserializeObject<SampleObjectWithPrivatePropWithNoConstructor>(serializedVal, _settings);

            Assert.Equal(val, deserializedVal);
        }

        private class SampleObjectWithPrivatePropWithNoConstructor : IEquatable<SampleObjectWithPrivatePropWithNoConstructor>
        {
            private int Val { get; set; } = 0;

            public bool Equals(SampleObjectWithPrivatePropWithNoConstructor? other) => other != null && Val == other.Val;
            public void Set(int val) => Val = val;
        }
    }
}

Is it possible to do something similar in System.Text.Json without using any attributes in the objects type definitions (without JsonIncludeAttribute)?

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I used ContractResolver.CreateProperties override option to mark using reflection all properties including private ones to be serialized and deserialized using the following code:

    public class NewtonesoftSample
    {
        private JsonSerializerSettings _settings;

        public NewtonesoftSample()
        {
            _settings = new JsonSerializerSettings() { ContractResolver = new MyContractResolver() };
        }

        public class MyContractResolver : Newtonsoft.Json.Serialization.DefaultContractResolver
        {
            protected override IList<JsonProperty> CreateProperties(Type type, MemberSerialization memberSerialization)
            {
                var props = type.GetProperties(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)
                                .Select(property => base.CreateProperty(property, memberSerialization))
                                .Union(type.GetFields(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)
                                .Select(field => base.CreateProperty(field, memberSerialization)))
                                .ToList();
                props.ForEach(p => { p.Writable = true; p.Readable = true; });
                return props;
            }
        }

        [Fact]
        public void Validate_SampleObjectWithPrivatePropWithNoConstructor()
        {
            var val = new SampleObjectWithPrivatePropWithNoConstructor();
            val.Set(val: 2);
            var serializedVal = JsonConvert.SerializeObject(val, _settings);
            var deserializedVal = JsonConvert.DeserializeObject<SampleObjectWithPrivatePropWithNoConstructor>(serializedVal, _settings);

            Assert.Equal(val, deserializedVal);
        }

        private class SampleObjectWithPrivatePropWithNoConstructor : IEquatable<SampleObjectWithPrivatePropWithNoConstructor>
        {
            private int Val { get; set; } = 0;

            public bool Equals(SampleObjectWithPrivatePropWithNoConstructor? other) => other != null && Val == other.Val;
            public void Set(int val) => Val = val;
        }
    }

Is it possible to do something similar in System.Text.Json without using any attributes in the objects type definitions (without JsonIncludeAttribute)?

Author:	RonenGlants
Assignees:	-
Labels:	area-System.Text.Json, untriaged
Milestone:	-

[RonenGlants]

#31257 refers to something similar but focuses on "ignore null values" which has a dedicated solution and not on my use case/end goal which is - generally include all private props in serialization and deserialization without knowing the specific type.

#36785 - related scope

[RonenGlants]

This / This solution requires me to have a dedicated converter to all the types in my system - which I would like to avoid.

[eiriktsarpalis]

You're correct to point out that this falls under the #36785 umbrella. I'll add it to that list for future consideration.

[gokhanabatay]

We also need this feature with NHibernate Proxy object serializations.

#31257 (comment)

[eiriktsarpalis]

Closing in favor of #63686.