Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono ARM64 JIT inconsistent with sign-extension #60649

Open
jkoritzinsky opened this issue Oct 19, 2021 · 6 comments
Open

Mono ARM64 JIT inconsistent with sign-extension #60649

jkoritzinsky opened this issue Oct 19, 2021 · 6 comments
Assignees
Labels
arch-arm64 area-Codegen-JIT-mono disabled-test The test is disabled in source code against the issue
Milestone

Comments

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Oct 19, 2021

The DllImportGenerator test DllImportGenerator.IntegrationTests.BooleanTests.ValidateBoolIsMarshalledAsExpected fails on Mono ARM64 due to inconsistencies with sign extension.

This assert fails:

Assert.Equal(VARIANT_TRUE, NativeExportsNE.ReturnVariantBoolAsUInt(true));
because the zero/sign extension is inconsistent with how the UnmanagedCallersOnly return at is extended.

Runfo Tracking Issue: DllImportGenerator.IntegrationTests.BooleanTests.ValidateBoolIsMarshalledAsExpected

Build Definition Kind Run Name

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 0
@agocke
Copy link
Member

agocke commented Oct 20, 2021

This is failing rolling builds -- if this was a recently introduced regression, can we revert and resubmit?

@jkoritzinsky
Copy link
Member Author

This is a long standing bug that was discovered by merging in the DllImportGenerator.

We can add an [ActiveIssue] attribute to the failing test and point it to this issue.

@agocke
Copy link
Member

agocke commented Oct 20, 2021

Either disabling the issue or reverting the DllImport merge would be good. Whichever one we choose should be based on whether this issue would be considered blocking

@jkoritzinsky
Copy link
Member Author

I think that given the scope of the merge, disabling the test is the correct approach.

@SamMonoRT
Copy link
Member

At this point, I think disabling the test is fine. @fanyang-mono to follow up. We should also figure out if the test lanes were enabled as part of PR runs, why this wasn't caught prior to merging. (Totally understand if this is a rolling build only test run).

@SamMonoRT SamMonoRT removed the untriaged New issue has not been triaged by the area owner label Oct 20, 2021
@SamMonoRT SamMonoRT added this to the 7.0.0 milestone Oct 20, 2021
@krwq krwq added the disabled-test The test is disabled in source code against the issue label Oct 22, 2021
@SamMonoRT SamMonoRT modified the milestones: 7.0.0, 8.0.0 Aug 4, 2022
@SamMonoRT SamMonoRT removed their assignment Aug 4, 2022
@fanyang-mono fanyang-mono modified the milestones: 8.0.0, 9.0.0 Jul 12, 2023
@fanyang-mono
Copy link
Member

Moving to 9.0.0

@steveisok steveisok modified the milestones: 9.0.0, Future Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm64 area-Codegen-JIT-mono disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

No branches or pull requests

6 participants