Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate ARM64 CFG failures when using the dispatcher #65111

Closed
jakobbotsch opened this issue Feb 9, 2022 · 2 comments · Fixed by #65127
Closed

Investigate ARM64 CFG failures when using the dispatcher #65111

jakobbotsch opened this issue Feb 9, 2022 · 2 comments · Fixed by #65127
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@jakobbotsch
Copy link
Member

Description

In the original PR I had a mistake in an ifdef chain that caused us to never enable the dispatcher, even when trying to forcibly enable it via environment variables (by default, ARM64 does not use the dispatcher). #65095 fixed it and there are interesting failures in the jit-cfg run there that should be investigated.

Reproduction Steps

See above.

Expected behavior

See above.

Actual behavior

See above.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

@jakobbotsch jakobbotsch self-assigned this Feb 9, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 9, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@jakobbotsch jakobbotsch added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed untriaged New issue has not been triaged by the area owner labels Feb 9, 2022
@ghost
Copy link

ghost commented Feb 9, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

In the original PR I had a mistake in an ifdef chain that caused us to never enable the dispatcher, even when trying to forcibly enable it via environment variables (by default, ARM64 does not use the dispatcher). #65095 fixed it and there are interesting failures in the jit-cfg run there that should be investigated.

Reproduction Steps

See above.

Expected behavior

See above.

Actual behavior

See above.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone: -

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 10, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Feb 11, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants