Consider hiding stack frames when using Invoke

[steveharter]

Per comment and reply from #67917 (comment) we should consider hiding the 2 extra outer (actual exception, not the inner) frames that we now have when an invoked method throws an exception which is subsequently wrapped with a TargetInvocationException.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Per comment and reply from #67917 (comment) we should consider hiding the 2 extra outer (actual exception, not the inner) frames that we now have when an invoked method throws an exception which is subsequently wrapped with a TargetInvocationException.

Author:	steveharter
Assignees:	steveharter
Labels:	area-System.Reflection, discussion
Milestone:	7.0.0

[steveharter]

It is generally agreed that we should be hiding the extra stack frames that were added due to Emit-based invoke. We either need reconcile why native code in SystemDomain::IsReflectionInvocationMethod isn't being called to skip stack frames in this case and\or add [StackTraceHidden] to the managed methods. Pending tests, we may also need to create a Mono issue associated with it.

[MarcoRossignoli]

Hi @steveharter I've noticed the same today during testing:

It wasn't here in past.

[steveharter]

Moving to v8 to consider. Not considered high priority.

I believe the last stack frame is always preserved with [StackTraceHidden], so we may need a different way to determine how to hide these frames.