Test failure System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu) #69474

VincentBu · 2022-05-18T01:42:21Z

Run: runtime-coreclr libraries-jitstress 20220517.1

Failed test:

net7.0-Linux-Release-arm64-CoreCLR_checked-no_tiered_compilation-(Ubuntu.1804.Arm64.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8-20210531091519-97d8652

- System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu)

Error message:

Assert.Equal() Failure
Expected: 2022-05-17T07:50:14.0000000+00:00
Actual:   2022-05-17T07:50:13.0000000+00:00


Stack trace
   at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.VerifyPlatformSpecificMetadata(String filePath, TarEntry entry) in /_/src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.Unix.cs:line 194
   at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format) in /_/src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.cs:line 110
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.RuntimeMethodInfo.InvokeNonEmitUnsafe(Object obj, IntPtr* arguments, Span`1 argsForTemporaryMonoSupport, BindingFlags invokeAttr) in /_/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs:line 383

No kusto information.

The text was updated successfully, but these errors were encountered:

dotnet-issue-labeler · 2022-05-18T01:42:24Z

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

ghost · 2022-05-18T02:18:32Z

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-coreclr libraries-jitstress 20220517.1

Failed test:

net7.0-Linux-Release-arm64-CoreCLR_checked-no_tiered_compilation-(Ubuntu.1804.Arm64.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8-20210531091519-97d8652

- System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu)

Error message:

Assert.Equal() Failure
Expected: 2022-05-17T07:50:14.0000000+00:00
Actual:   2022-05-17T07:50:13.0000000+00:00


Stack trace
   at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.VerifyPlatformSpecificMetadata(String filePath, TarEntry entry) in /_/src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.Unix.cs:line 194
   at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format) in /_/src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.cs:line 110
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.RuntimeMethodInfo.InvokeNonEmitUnsafe(Object obj, IntPtr* arguments, Span`1 argsForTemporaryMonoSupport, BindingFlags invokeAttr) in /_/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs:line 383

No kusto information.

Author:	VincentBu
Assignees:	-
Labels:	`arch-arm64`, `area-System.IO.Compression`, `os-linux`, `untriaged`
Milestone:	-

ghost · 2022-05-18T11:10:33Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-coreclr libraries-jitstress 20220517.1

Failed test:

net7.0-Linux-Release-arm64-CoreCLR_checked-no_tiered_compilation-(Ubuntu.1804.Arm64.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8-20210531091519-97d8652

- System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu)

Error message:

Assert.Equal() Failure
Expected: 2022-05-17T07:50:14.0000000+00:00
Actual:   2022-05-17T07:50:13.0000000+00:00


Stack trace
   at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.VerifyPlatformSpecificMetadata(String filePath, TarEntry entry) in /_/src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.Unix.cs:line 194
   at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format) in /_/src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.cs:line 110
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.RuntimeMethodInfo.InvokeNonEmitUnsafe(Object obj, IntPtr* arguments, Span`1 argsForTemporaryMonoSupport, BindingFlags invokeAttr) in /_/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs:line 383

No kusto information.

Author:	VincentBu
Assignees:	-
Labels:	`arch-arm64`, `area-System.IO`, `os-linux`, `untriaged`
Milestone:	-

jkotas · 2022-05-29T01:51:29Z

Failed in #69948

This is failing often enough to deserve blocking-clean-ci label.

MichalStrehovsky · 2022-05-31T00:34:02Z

Also failed in #69838. Different test, but likely the same problem (the seconds are off by one):

Exception Message

Assert.Equal() Failure
Expected: 2022-05-30T03:28:53.0000000+00:00
Actual: 2022-05-30T03:28:52.0000000+00:00

Stack Trace

at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.VerifyPlatformSpecificMetadata(String filePath, TarEntry entry) in //src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.Unix.cs:line 195
at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(TarFormat format, Boolean createTarget) in //src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.cs:line 207
at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_SymbolicLink(Object, Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

carlossanlop · 2022-05-31T05:03:32Z

The Kusto query tells me this is happening in:

PRs only (no rolling builds)
Linux only, specifically Ubuntu 18.04 and redhat 7.
x64 and arm architectures.

Jobs
| project JobId, Source, Build, Started, Type
| where Started > ago(15d)
| where Type startswith "test/functional/cli/innerloop"
| where Source == "pr/public/dotnet/runtime/refs/heads/main" or Source startswith "pr/public/dotnet/runtime/refs/pull"
| join kind=inner
	(TestResults | project Result, WorkItemId, JobId, WorkItemFriendlyName, Method, StackTrace, WorkItemName) on JobId
| where Result == "Fail"
| where Method == "Add_File"
| where WorkItemFriendlyName == "System.Formats.Tar.Tests"
| where StackTrace has "VerifyPlatformSpecificMetadata"
| join kind=inner 
    (WorkItems | project WorkItemId, QueueName) on WorkItemId

There are 22 hits in the last 30 days.

As Michal mentioned, the test is failing because the timestamp comparison is differing by one second. This is strange, because the archive entry's timestamp that is converted from integer to DateTimeOffset is what is set in the file that the test extracts to disk. Then the test uses very similar logic to read that timestamp from the extracted file directly, and compares it. The number should be the same.

Update: Pushed PR #69997 to disable the test to unblock PRs.

danmoseley · 2022-06-06T22:10:07Z

removing label as test was disabled.

VincentBu · 2022-06-13T02:11:16Z

Failed again in: runtime-coreclr libraries-jitstressregs 20220612.1

Failed test:

net7.0-windows-Release-arm64-CoreCLR_checked-jitstressregs4-Windows.10.Arm64v8.Open

- System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu)

Error message:

Assert.Equal() Failure
Expected: 50
Actual:   49


Stack trace
   at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.VerifyTimestamp(DateTime expected, DateTimeOffset actual) in /_/src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.Windows.cs:line 76
   at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.VerifyPlatformSpecificMetadata(String filePath, TarEntry entry) in /_/src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.Windows.cs:line 63
   at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarEntryFormat format) in /_/src/libraries/System.Formats.Tar/tests/TarWriter/TarWriter.WriteEntry.File.Tests.cs:line 111
   at InvokeStub_TarWriter_WriteEntry_File_Tests.Add_File(Object, Object, IntPtr*)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

MichalStrehovsky · 2022-06-13T03:19:42Z

I haven't looked in detail but it looked like whatever we're validating here was roundripped through a floating-point number in the TAR file format - that raises a red flag around precisions and off-by-one roundings. It should be possible to validate this is caused by rounding by roundtripping all possible integer timestamps within one second through the file format and seeing what comes out on the integer side again.

carlossanlop · 2022-06-13T06:29:17Z

I haven't looked in detail but it looked like whatever we're validating here was roundripped through a floating-point number in the TAR file format - that raises a red flag around precisions and off-by-one roundings. It should be possible to validate this is caused by rounding by roundtripping all possible integer timestamps within one second through the file format and seeing what comes out on the integer side again.

Thank you, @MichalStrehovsky. I am currently working on changing all the tar tests to avoid expecting exact values. But I will also test what you're suggesting, in case the conversion logic from/to DateTimeOffset/double is wrong.

cc @tannergooding @dakersnar

tannergooding · 2022-06-13T15:07:55Z

There may be a bug for certain values, but it is worth noting that guaranteeing roundtripping for long->double->long isn't possible because its by definition a lossy operation for integers over 2^52.

MichalStrehovsky · 2022-06-21T03:53:59Z

Another similarly looking failure in System.Formats.Tar.Tests.V7TarEntry_Conversion_Tests.Constructor_ConversionGnu_BackAndForth_SymbolicLink:

    System.Formats.Tar.Tests.V7TarEntry_Conversion_Tests.Constructor_ConversionGnu_BackAndForth_SymbolicLink [FAIL]
      Assert.Equal() Failure
      Expected: 27
      Actual:   28
      Stack Trace:
        /_/src/libraries/System.Formats.Tar/tests/TarTestsBase.cs(311,0): at System.Formats.Tar.Tests.TarTestsBase.CompareDateTimeOffsets(DateTimeOffset expected, DateTimeOffset actual)
        /_/src/libraries/System.Formats.Tar/tests/TarEntry/TarEntry.Conversion.Tests.Base.cs(152,0): at System.Formats.Tar.Tests.TarTestsConversionBase.ConvertAndVerifyEntry(TarEntry originalEntry, TarEntryType entryType, TarEntryFormat formatToConvert, DateTimeOffset initialNow)
        /_/src/libraries/System.Formats.Tar/tests/TarEntry/TarEntry.Conversion.Tests.Base.cs(45,0): at System.Formats.Tar.Tests.TarTestsConversionBase.TestConstructionConversionBackAndForth(TarEntryType originalEntryType, TarEntryFormat firstAndLastFormat, TarEntryFormat formatToConvert)
        /_/src/libraries/System.Formats.Tar/tests/TarEntry/V7TarEntry.Conversion.Tests.cs(218,0): at System.Formats.Tar.Tests.V7TarEntry_Conversion_Tests.Constructor_ConversionGnu_BackAndForth_SymbolicLink()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs(69,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
    System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_CharacterDevice [SKIP]
      Condition(s) not met: "IsRemoteExecutorSupportedAndOnUnixAndSuperUser"
    System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Fifo [SKIP]
      Condition(s) not met: "IsRemoteExecutorSupportedAndOnUnixAndSuperUser"
  Finished:    System.Formats.Tar.Tests
=== TEST EXECUTION SUMMARY ===
   System.Formats.Tar.Tests  Total: 440, Errors: 0, Failed: 1, Skipped: 3, Time: 3.042s

There are several tests with this failure mode, but only one of them got disabled. #69997 (comment)

The latest one hit in https://dev.azure.com/dnceng/public/_build/results?buildId=1835642&view=logs&jobId=ee1d0ee6-ff1e-56e7-4a8c-87d1cd9cc235.

I'm putting back blocking clean CI label.

VincentBu · 2022-06-22T01:18:27Z

Failed again in: runtime-coreclr libraries-jitstress 20220621.1

Failed test:

net7.0-Linux-Release-arm64-CoreCLR_checked-jitstress1-(Ubuntu.1804.Arm64.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8-20210531091519-97d8652

- System.Formats.Tar.Tests.V7TarEntry_Conversion_Tests.Constructor_ConversionGnu_BackAndForth_SymbolicLink

net7.0-Linux-Release-arm64-CoreCLR_checked-jitstress2-(Ubuntu.1804.Arm64.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm64v8-20210531091519-97d8652

- System.Formats.Tar.Tests.V7TarEntry_Conversion_Tests.Constructor_ConversionGnu_BackAndForth_SymbolicLink

Error message:

Assert.Equal() Failure
Expected: 44
Actual:   45


Stack trace
   at System.Formats.Tar.Tests.TarTestsBase.CompareDateTimeOffsets(DateTimeOffset expected, DateTimeOffset actual) in /_/src/libraries/System.Formats.Tar/tests/TarTestsBase.cs:line 311
   at System.Formats.Tar.Tests.TarTestsConversionBase.ConvertAndVerifyEntry(TarEntry originalEntry, TarEntryType entryType, TarEntryFormat formatToConvert, DateTimeOffset initialNow) in /_/src/libraries/System.Formats.Tar/tests/TarEntry/TarEntry.Conversion.Tests.Base.cs:line 152
   at System.Formats.Tar.Tests.TarTestsConversionBase.TestConstructionConversionBackAndForth(TarEntryType originalEntryType, TarEntryFormat firstAndLastFormat, TarEntryFormat formatToConvert) in /_/src/libraries/System.Formats.Tar/tests/TarEntry/TarEntry.Conversion.Tests.Base.cs:line 45
   at System.Formats.Tar.Tests.V7TarEntry_Conversion_Tests.Constructor_ConversionGnu_BackAndForth_SymbolicLink() in /_/src/libraries/System.Formats.Tar/tests/TarEntry/V7TarEntry.Conversion.Tests.cs:line 218
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs:line 64

VincentBu added arch-arm64 os-linux Linux OS (any supported distro) labels May 18, 2022

ghost added the untriaged New issue has not been triaged by the area owner label May 18, 2022

danmoseley added the area-System.IO.Compression label May 18, 2022

danmoseley added area-System.IO and removed area-System.IO.Compression labels May 18, 2022

adamsitnik assigned carlossanlop May 18, 2022

sbomer mentioned this issue May 20, 2022

[main] Update dependencies from dotnet/linker #69246

Merged

jkotas mentioned this issue May 29, 2022

Rename NativeMemory.ZeroMemory #69948

Merged

jkotas added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label May 29, 2022

runfoapp bot mentioned this issue May 30, 2022

Infrastructure - Status/Health #702

Closed

MichalStrehovsky mentioned this issue May 31, 2022

[NativeAot] Null ref return is wrapped in TargetInvocationException #69838

Merged

carlossanlop added this to the 7.0.0 milestone May 31, 2022

ghost removed the untriaged New issue has not been triaged by the area owner label May 31, 2022

This was referenced May 31, 2022

Disable TarWriter_WriteEntry_File_Tests.Add_File in Linux #69997

Merged

Tar APIs pending feedback to address #68230

Open

AndyAyersMS mentioned this issue Jun 3, 2022

JIT: fix invariant analysis for cloning #70126

Merged

danmoseley removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jun 6, 2022

carlossanlop mentioned this issue Jun 9, 2022

Add TarEntry conversion constructors #70325

Merged

AaronRobinsonMSFT mentioned this issue Jun 17, 2022

Remove #define Sleep #70868

Merged

carlossanlop mentioned this issue Jun 21, 2022

Fix Tar timestamp conversion from/to string and DateTimeOffset #71038

Merged

ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 21, 2022

MichalStrehovsky added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jun 21, 2022

MichalStrehovsky mentioned this issue Jun 21, 2022

Ensure consistent reflectability for generic methods #70977

Merged

AndyAyersMS mentioned this issue Jun 22, 2022

JIT: arm64 osr funclet frame probing #70916

Merged

carlossanlop closed this as completed in #71038 Jun 23, 2022

ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 23, 2022

ghost locked as resolved and limited conversation to collaborators Jul 23, 2022

jeffhandley added area-System.Formats.Tar and removed area-System.IO labels Nov 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test failure System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu) #69474

Test failure System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu) #69474

VincentBu commented May 18, 2022

dotnet-issue-labeler bot commented May 18, 2022

ghost commented May 18, 2022

ghost commented May 18, 2022

jkotas commented May 29, 2022

MichalStrehovsky commented May 31, 2022

carlossanlop commented May 31, 2022 •

edited

Loading

danmoseley commented Jun 6, 2022

VincentBu commented Jun 13, 2022

MichalStrehovsky commented Jun 13, 2022

carlossanlop commented Jun 13, 2022

tannergooding commented Jun 13, 2022

MichalStrehovsky commented Jun 21, 2022

VincentBu commented Jun 22, 2022

Test failure System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu) #69474

Test failure System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu) #69474

Comments

VincentBu commented May 18, 2022

dotnet-issue-labeler bot commented May 18, 2022

ghost commented May 18, 2022

ghost commented May 18, 2022

jkotas commented May 29, 2022

MichalStrehovsky commented May 31, 2022

carlossanlop commented May 31, 2022 • edited Loading

danmoseley commented Jun 6, 2022

VincentBu commented Jun 13, 2022

MichalStrehovsky commented Jun 13, 2022

carlossanlop commented Jun 13, 2022

tannergooding commented Jun 13, 2022

MichalStrehovsky commented Jun 21, 2022

VincentBu commented Jun 22, 2022

carlossanlop commented May 31, 2022 •

edited

Loading