-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Regressions in System.Buffers.Tests.RentReturnArrayPoolTests<Byte> #70845
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Could be related to #70478 |
Tagging subscribers to this area: @mangod9 Issue DetailsRun Information
Regressions in System.Buffers.Tests.RentReturnArrayPoolTests<Byte>
Reprogit clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Buffers.Tests.RentReturnArrayPoolTests<Byte>*' PayloadsHistogramSystem.Buffers.Tests.RentReturnArrayPoolTests<Byte>.ProducerConsumer(RentalSize: 4096, ManipulateArray: False, Async: False, UseSharedPool: False)
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository
Regressions in System.Buffers.Tests.RentReturnArrayPoolTests<Object>
Reprogit clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Buffers.Tests.RentReturnArrayPoolTests<Object>*' PayloadsHistogramSystem.Buffers.Tests.RentReturnArrayPoolTests<Object>.ProducerConsumer(RentalSize: 4096, ManipulateArray: False, Async: False, UseSharedPool: False)
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository
|
I am closing this since looking at the chart there appears to be a dip and then a bump to a normal pattern, also the threadpool change should have nothing to do with this test. |
I've confirmed that #70478 is not the cause of the regression. On one of my arm64 machines, these tests have ~30-50% StdDev within a single run, so the change in value may not be significant. Looking at a narrower diff of changes that caused the relevant regression (example for the first test), it doesn't look like any other change would cause it either. It seems the regressions have recovered or are within reasonable error margin. |
Run Information
Regressions in System.Buffers.Tests.RentReturnArrayPoolTests<Byte>
Test Report
Repro
Payloads
Baseline
Compare
Histogram
System.Buffers.Tests.RentReturnArrayPoolTests<Byte>.ProducerConsumer(RentalSize: 4096, ManipulateArray: False, Async: False, UseSharedPool: False)
Description of detection logic
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Regressions in System.Buffers.Tests.RentReturnArrayPoolTests<Object>
Test Report
Repro
Payloads
Baseline
Compare
Histogram
System.Buffers.Tests.RentReturnArrayPoolTests<Object>.ProducerConsumer(RentalSize: 4096, ManipulateArray: False, Async: False, UseSharedPool: False)
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: