Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Text.Json serialization callbacks not supported by collection types #71945

Closed
Tracked by #71967
eiriktsarpalis opened this issue Jul 11, 2022 · 4 comments · Fixed by #104120
Closed
Tracked by #71967

System.Text.Json serialization callbacks not supported by collection types #71945

eiriktsarpalis opened this issue Jul 11, 2022 · 4 comments · Fixed by #104120
Labels
area-System.Text.Json enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors in-pr There is an active PR which will close this issue when it is merged
Milestone
Future

Comments

@eiriktsarpalis
Copy link
Member

The System.Text.Json serialization callbacks are currently not supported by collection/dictionary converters, even though they could be. The newly released callback APIs in the System.Text.Json contract model reflect that behavior, but we should consider changing that in the future.
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 11, 2022
@ghost
Copy link

ghost commented Jul 11, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

The System.Text.Json serialization callbacks are currently not supported by collection/dictionary converters, even though they could be. The newly released callback APIs in the System.Text.Json contract model reflect that behavior, but we should consider changing that in the future.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Jul 11, 2022
@eiriktsarpalis eiriktsarpalis added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Jul 11, 2022
@eiriktsarpalis eiriktsarpalis mentioned this issue Jul 11, 2022
Open
9 tasks
@krwq
Copy link
Member

krwq commented Sep 28, 2022

we should think about populating existing collections when fixing this

@krwq
Copy link
Member

krwq commented Sep 28, 2022

ref: #30258

@eiriktsarpalis eiriktsarpalis mentioned this issue Jan 10, 2023
Merged
@eiriktsarpalis eiriktsarpalis modified the milestones: 8.0.0, Future Jan 23, 2023
@eiriktsarpalis eiriktsarpalis added the help wanted [up-for-grabs] Good issue for external contributors label Jan 23, 2023
@eiriktsarpalis
Copy link
Member Author

Moving to Future as we won't be able to work on this for 8.0

@manandre manandre mentioned this issue Jun 27, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jun 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Text.Json enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

STJ: Support serialization callbacks for collection and dictionary types manandre/runtime
2 participants
@krwq @eiriktsarpalis