Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Text.Json should handle attributes in virtual or shadowed properties consistently #73255

Open
6 of 11 tasks
Tracked by #63918
eiriktsarpalis opened this issue Aug 2, 2022 · 2 comments
Open
6 of 11 tasks
Tracked by #63918
Labels
area-System.Text.Json Cost:L Work that requires one engineer up to 4 weeks enhancement Product code improvement that does NOT require public API changes/additions Team:Libraries User Story A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@eiriktsarpalis
Copy link
Member

eiriktsarpalis commented Aug 2, 2022

Currently, System.Text.Json suffers from a few consistency/reliability bugs when it comes to consuming attributes defined in virtual/shadowed property hierarchies. These also manifest as divergences between reflection-based and source generated contract resolution semantics. We should try to fix as many of these as possible and expand our test coverage in this space. It might be the case that we need to introduce strategic breaking changes if absolutely necessary.

Provisional list of customer reported issues:

@eiriktsarpalis eiriktsarpalis added area-System.Text.Json User Story A single user-facing feature. Can be grouped under an epic. Cost:L Work that requires one engineer up to 4 weeks labels Aug 2, 2022
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Aug 2, 2022
@ghost
Copy link

ghost commented Aug 2, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently, System.Text.Json suffers from a few consistency/reliability bugs when it comes to consuming attributes defined in virtual/shadowed property hierarchies. These also manifest as divergences between reflection-based and source generated contract resolution semantics. We should try to fix as many of these as possible and expand our test coverage in this space. It might be the case that we need to introduce strategic breaking changes if absolutely necessary.

Provisional list of customer reported issues:

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json, User Story, Cost:L

Milestone: 8.0.0

@eiriktsarpalis
Copy link
Member Author

Moving to Future as we won't be able to work on this for 8.0

@eiriktsarpalis eiriktsarpalis changed the title System.Text.Json should handle attributes in virtual properties consistently System.Text.Json should handle attributes in virtual or overridden properties consistently Feb 19, 2024
@eiriktsarpalis eiriktsarpalis changed the title System.Text.Json should handle attributes in virtual or overridden properties consistently System.Text.Json should handle attributes in virtual or shadowed properties consistently Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Text.Json Cost:L Work that requires one engineer up to 4 weeks enhancement Product code improvement that does NOT require public API changes/additions Team:Libraries User Story A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Development

No branches or pull requests

1 participant