Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Text.Json.Nodes.Tests.JsonArrayTests.HeterogeneousArray - asserts #73538

Closed
karelz opened this issue Aug 7, 2022 · 5 comments
Closed

Comments

@karelz
Copy link
Member

karelz commented Aug 7, 2022

Occurrences 7/7-8/7 (incl. PRs) from Runfo in last 30 days:

Day Run OS
8/6 Rolling run - 1927956 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
8/6 PR #73515 - 1927732 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
8/3 PR #73214 - 1922072 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
7/15 Rolling run - 1882819 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
7/11 PR #71943 - 1872339 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
Assert.Equal() Failure
Expected: NaN
Actual:   2.2999999999999998

   at System.Text.Json.Nodes.Tests.JsonArrayTests.HeterogeneousArray() in /_/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonArrayTests.cs:line 435
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 7, 2022
@ghost
Copy link

ghost commented Aug 7, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Occurrences 4/5-8/7 (incl. PRs) from Runfo in last 120 days:

Day Run OS
8/6 Rolling run - 1927956 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
8/6 PR #73515 - 1927732 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
8/3 PR #73214 - 1922072 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
7/15 Rolling run - 1882819 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
7/11 PR #71943 - 1872339 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
Assert.Equal() Failure
Expected: NaN
Actual:   2.2999999999999998

   at System.Text.Json.Nodes.Tests.JsonArrayTests.HeterogeneousArray() in /_/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonArrayTests.cs:line 435
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
Author: karelz
Assignees: -
Labels:

area-System.Text.Json, os-android, runtime-mono

Milestone: -

@karelz
Copy link
Member Author

karelz commented Aug 7, 2022

@lewing looks like Android specific, can you please help route it?

@akoeplinger
Copy link
Member

The Expected: NaN is extremely suspicious here since that is the expected value in this assert which should be 2.3:

Assert.Equal(2.3, mixedTypesArray[4].GetValue<double>());

We recently did a major change to the x86 floating point handling in #65723, there's a good chance this is fixed by that.

Let's keep an eye on it and see if it happens again.

@akoeplinger akoeplinger added this to the 8.0.0 milestone Aug 12, 2022
@akoeplinger akoeplinger removed the untriaged New issue has not been triaged by the area owner label Aug 12, 2022
@eiriktsarpalis eiriktsarpalis modified the milestones: 8.0.0, Future Sep 27, 2022
@ghost
Copy link

ghost commented Sep 27, 2022

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

Occurrences 7/7-8/7 (incl. PRs) from Runfo in last 30 days:

Day Run OS
8/6 Rolling run - 1927956 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
8/6 PR #73515 - 1927732 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
8/3 PR #73214 - 1922072 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
7/15 Rolling run - 1882819 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
7/11 PR #71943 - 1872339 net7.0-Android-Release-x86-Mono_Release-Ubuntu.1804.Amd64.Android.29.Open
Assert.Equal() Failure
Expected: NaN
Actual:   2.2999999999999998

   at System.Text.Json.Nodes.Tests.JsonArrayTests.HeterogeneousArray() in /_/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonArrayTests.cs:line 435
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
Author: karelz
Assignees: -
Labels:

area-System.Text.Json, os-android, area-Codegen-Interpreter-mono, runtime-mono

Milestone: Future

@akoeplinger
Copy link
Member

I don't see recent failures for this one so it is presumably fixed by #65723.

Closing.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants