Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SynthesizeRecognizeTests.SpeechSynthesizerToSpeechRecognitionEngine - NullReferenceException #76626

Closed
runfoapp bot opened this issue Oct 4, 2022 · 7 comments · Fixed by #76652
Closed

Comments

@runfoapp
Copy link

runfoapp bot commented Oct 4, 2022

Runfo Tracking Issue: SynthesizeRecognizeTests.SpeechSynthesizerToSpeechRecognitionEngine - NullReferenceException

Build Definition Kind Run Name Console Core Dump Test Results Run Client
40947 runtime PR 76652 net7.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py
40192 runtime PR 76623 net7.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py
39459 runtime PR 76582 net7.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
1 3 3
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 4, 2022
@danmoseley
Copy link
Member

danmoseley commented Oct 4, 2022

apparently here?

Assert.True(result.Confidence > 0.1);

looks like this means the timeout expired for recognition - for some reason.

options

  1. register for SpeechRecognitionRejected event, triggered by check here. question is -- does that count as a pass? if it does, how do we know recognition ever works

    FireSpeechRecognitionRejectedEvent(result);

  2. increase the timeout. default is 30 secs. looks like InitialSilenceTimeout allows that (despite the name)

    TimeSpan eventTimeout = TimeSpan.FromTicks(Math.Max(initialSilenceTimeout.Ticks, _defaultTimeout.Ticks));

Seems like 2 is reasonable to start.

@danmoseley
Copy link
Member

BTW, this test is kind of the "key" test that verifies recognition works so I would recommend not disabling it as a first approach.

@ghost
Copy link

ghost commented Oct 4, 2022

Tagging subscribers to this area: @danmoseley
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Tracking Issue: SynthesizeRecognizeTests.SpeechSynthesizerToSpeechRecognitionEngine - NullReferenceException

Build Definition Kind Run Name Console Core Dump Test Results Run Client
39459 runtime PR 76582 net7.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open console.log runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
1 1 1
Author: runfoapp[bot]
Assignees: -
Labels:

untriaged, area-System.Speech

Milestone: -

@danmoseley
Copy link
Member

@jeffhandley apparently the bot json didn't get picked up yet as I got tagged 😸

@jeffhandley
Copy link
Member

We've not made the change yet. Thanks for tagging me.

@danmoseley
Copy link
Member

I'm looking at improving the test.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 5, 2022
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Oct 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants