Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set profile weights correctly for the Internal blocks in JIT/Directed/UnrollLoop/loop3_il_d.exe #7727

Closed
briansull opened this issue Mar 25, 2017 · 3 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions JitUntriaged CLR JIT issues needing additional triage optimization tenet-performance Performance related issue
Milestone

Comments

@briansull
Copy link
Contributor

For JustMyCode debuggable code we insert a GT_QMARK tree that gets expanded into 3 Blocks
to conditionally call HELPER.CORINFO_HELP_DBG_IS_JUST_MY_CODE

We need to update the block weights for these internal blocks to use the profile weights.

category:cq
theme:profile-feedback
skill-level:intermediate
cost:medium

@briansull
Copy link
Contributor Author

set COMPLUS_JitStress=2
run JIT\Directed\UnrollLoop\loop3_il_d.exe

@gkhanna79
Copy link
Member

CC @RussKeldorph

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@AndyAyersMS AndyAyersMS mentioned this issue Oct 19, 2020
54 tasks
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@AndyAyersMS
Copy link
Member

Not sure we care that much about getting correct profile weights for debuggable code. Though I suppose if we were thinking of using partial compilation to improve debug innerloop we might care somewhat.

But that would seemingly lead to other complications, like whether we could do EnC from a partially compiled method or one of its fragments.

At any rate, I am going to close this.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions JitUntriaged CLR JIT issues needing additional triage optimization tenet-performance Performance related issue
Projects
None yet
Development

No branches or pull requests

5 participants