Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Linux/x64: 5 Regressions on 11/7/2022 8:57:30 PM #78819

Closed
performanceautofiler bot opened this issue Nov 15, 2022 · 4 comments
Closed

[Perf] Linux/x64: 5 Regressions on 11/7/2022 8:57:30 PM #78819

performanceautofiler bot opened this issue Nov 15, 2022 · 4 comments
Assignees
@GrabYourPitchforks @stephentoub
Labels
arch-x64 os-linux Linux OS (any supported distro)

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS ubuntu 18.04
Baseline bfa4812aec806f09f1e2927939ba98118e5e5bf7
Compare 2aebbf75167b3aa21cae23e6fd702688dd724663
Diff Diff

Regressions in System.IO.Tests.StreamReaderReadLineTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ReadLine - Duration of single invocation 2.17 ms 2.87 ms 1.32 0.06 False
ReadLineAsync - Duration of single invocation 7.87 ms 8.83 ms 1.12 0.02 False
ReadLineAsync - Duration of single invocation 5.44 ms 6.11 ms 1.12 0.02 False
ReadLine - Duration of single invocation 1.00 ms 1.20 ms 1.20 0.02 False
ReadLine - Duration of single invocation 1.44 ms 2.78 ms 1.93 0.10 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.IO.Tests.StreamReaderReadLineTests*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.IO.Tests.StreamReaderReadLineTests.ReadLine(LineLengthRange: [ 1, 1])

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 2.867710533035714 > 2.2779075627232146.
IsChangePoint: Marked as a change because one of 11/7/2022 4:10:19 PM, 11/9/2022 12:33:05 PM falls between 10/31/2022 10:23:25 PM and 11/9/2022 12:33:05 PM.
IsRegressionStdDev: Marked as regression because -45.737317654453825 (T) = (0 -2827012.2266411446) / Math.Sqrt((935224353.7297976 / (34)) + (1573380320.5073526 / (9))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (34) + (9) - 2, .025) and -0.29891728487741454 = (2176437.452603415 - 2827012.2266411446) / 2176437.452603415 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Tests.StreamReaderReadLineTests.ReadLineAsync(LineLengthRange: [   0,    0])

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 8.83086421234568 > 8.354521890859376.
IsChangePoint: Marked as a change because one of 10/11/2022 6:23:40 AM, 11/7/2022 4:10:19 PM, 11/9/2022 12:33:05 PM falls between 10/31/2022 10:23:25 PM and 11/9/2022 12:33:05 PM.
IsRegressionStdDev: Marked as regression because -18.818323443483127 (T) = (0 -8806382.037386755) / Math.Sqrt((10311261469.927258 / (39)) + (16172468653.041828 / (9))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (39) + (9) - 2, .025) and -0.10744318226642255 = (7951994.448477415 - 8806382.037386755) / 7951994.448477415 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Tests.StreamReaderReadLineTests.ReadLineAsync(LineLengthRange: [   1,    1])

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 6.106538740972222 > 5.762564026770834.
IsChangePoint: Marked as a change because one of 10/11/2022 6:23:40 AM, 11/7/2022 4:10:19 PM, 11/9/2022 12:33:05 PM falls between 10/31/2022 10:23:25 PM and 11/9/2022 12:33:05 PM.
IsRegressionStdDev: Marked as regression because -8.20084868959333 (T) = (0 -6029245.932091982) / Math.Sqrt((5220979268.262066 / (38)) + (34709613658.238464 / (9))) is less than -2.0141033888794695 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (38) + (9) - 2, .025) and -0.0940450663295408 = (5510966.702971168 - 6029245.932091982) / 5510966.702971168 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Tests.StreamReaderReadLineTests.ReadLine(LineLengthRange: [   1,    8])

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 1.2047588010355026 > 1.0580547114375.
IsChangePoint: Marked as a change because one of 9/28/2022 9:30:44 PM, 11/7/2022 4:10:19 PM, 11/9/2022 12:33:05 PM falls between 10/31/2022 10:23:25 PM and 11/9/2022 12:33:05 PM.
IsRegressionStdDev: Marked as regression because -45.49311623392584 (T) = (0 -1213659.5118370915) / Math.Sqrt((158887970.85989988 / (34)) + (146237957.30757207 / (9))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (34) + (9) - 2, .025) and -0.20693423258645482 = (1005572.2002649842 - 1213659.5118370915) / 1005572.2002649842 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.IO.Tests.StreamReaderReadLineTests.ReadLine(LineLengthRange: [   0,    0])

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 2.7812193409722226 > 1.5213529001420454.
IsChangePoint: Marked as a change because one of 11/7/2022 4:10:19 PM, 11/9/2022 12:33:05 PM falls between 10/31/2022 10:23:25 PM and 11/9/2022 12:33:05 PM.
IsRegressionStdDev: Marked as regression because -74.80257446592816 (T) = (0 -2800359.7077711644) / Math.Sqrt((2171980875.930978 / (34)) + (2277169065.928959 / (9))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (34) + (9) - 2, .025) and -0.9066322904245024 = (1468746.6072168944 - 2800359.7077711644) / 1468746.6072168944 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added refs/heads/main untriaged New issue has not been triaged by the area owner labels Nov 15, 2022
@kotlarmilos
Copy link
Member

Regression in 02c3e95

@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 16, 2022
@kotlarmilos kotlarmilos mentioned this issue Nov 16, 2022
Closed
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@kotlarmilos kotlarmilos transferred this issue from dotnet/perf-autofiling-issues Nov 24, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@kotlarmilos
Copy link
Member

@GrabYourPitchforks do you have any idea why it caused regressions?

@stephentoub
Copy link
Member

#78401 (comment)

@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2022
@jeffhandley jeffhandley added os-linux Linux OS (any supported distro) arch-x64 and removed refs/heads/main labels Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@GrabYourPitchforks GrabYourPitchforks

@stephentoub stephentoub

Labels
arch-x64 os-linux Linux OS (any supported distro)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeffhandley @GrabYourPitchforks @stephentoub @kotlarmilos