Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 5 Regressions on 11/17/2022 12:32:52 PM #78825

Closed
performanceautofiler bot opened this issue Nov 22, 2022 · 3 comments
Closed

[Perf] Linux/x64: 5 Regressions on 11/17/2022 12:32:52 PM #78825

performanceautofiler bot opened this issue Nov 22, 2022 · 3 comments
Assignees
Labels
arch-x64 area-Codegen-meta-mono os-linux Linux OS (any supported distro)

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS ubuntu 18.04
Baseline e2c0735927642a11162c0d12799be2921bd1c984
Compare 4acfa64fe963203c347e68f4adfc66de516967e4
Diff Diff

Regressions in System.Text.Tests.Perf_StringBuilder

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ToString_SingleSegment - Duration of single invocation 70.08 μs 81.32 μs 1.16 0.09 False
Append_Char - Duration of single invocation 2.79 μs 3.04 μs 1.09 0.07 False
Append_Char - Duration of single invocation 2.08 ms 2.31 ms 1.11 0.13 False
Append_Char_Capacity - Duration of single invocation 2.18 μs 2.42 μs 1.11 0.09 False
Append_Char_Capacity - Duration of single invocation 2.07 ms 2.31 ms 1.11 0.10 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Tests.Perf_StringBuilder*'

Payloads

Baseline
Compare

Histogram

System.Text.Tests.Perf_StringBuilder.ToString_SingleSegment(length: 100000)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 81.31830226876092 > 73.33566479875233.
IsChangePoint: Marked as a change because one of 11/17/2022 4:58:45 AM, 11/22/2022 2:20:42 AM falls between 11/9/2022 12:33:05 PM and 11/22/2022 2:20:42 AM.
IsRegressionStdDev: Marked as regression because -8.742373297932168 (T) = (0 -79287.7640078365) / Math.Sqrt((6367863.092334642 / (25)) + (16406218.490163228 / (22))) is less than -2.0141033888794695 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (25) + (22) - 2, .025) and -0.12395696316361432 = (70543.41634635576 - 79287.7640078365) / 70543.41634635576 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Tests.Perf_StringBuilder.Append_Char(length: 100)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 3.040995708822793 > 2.9347336728697218.
IsChangePoint: Marked as a change because one of 7/31/2022 5:42:25 AM, 11/15/2022 8:48:03 PM, 11/22/2022 2:20:42 AM falls between 11/9/2022 12:33:05 PM and 11/22/2022 2:20:42 AM.
IsRegressionStdDev: Marked as regression because -19.661992936967057 (T) = (0 -3063.5104540299253) / Math.Sqrt((299.63701425348734 / (19)) + (4814.59045315591 / (28))) is less than -2.0141033888794695 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (28) - 2, .025) and -0.09641349997843048 = (2794.119603680722 - 3063.5104540299253) / 2794.119603680722 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Tests.Perf_StringBuilder.Append_Char(length: 100000)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 2.309316656547619 > 2.1859646965820314.
IsChangePoint: Marked as a change because one of 8/5/2022 10:47:59 PM, 11/15/2022 8:48:03 PM, 11/22/2022 2:20:42 AM falls between 11/9/2022 12:33:05 PM and 11/22/2022 2:20:42 AM.
IsRegressionStdDev: Marked as regression because -22.387438715555096 (T) = (0 -2317815.0615972145) / Math.Sqrt((434514666.46297526 / (19)) + (2217621692.8016944 / (28))) is less than -2.0141033888794695 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (28) - 2, .025) and -0.1081352774510591 = (2091635.478773557 - 2317815.0615972145) / 2091635.478773557 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Tests.Perf_StringBuilder.Append_Char_Capacity(length: 100)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 2.424258876026019 > 2.2893951351459925.
IsChangePoint: Marked as a change because one of 8/5/2022 4:49:35 PM, 11/15/2022 8:48:03 PM, 11/22/2022 2:20:42 AM falls between 11/9/2022 12:33:05 PM and 11/22/2022 2:20:42 AM.
IsRegressionStdDev: Marked as regression because -25.330662490296547 (T) = (0 -2398.1996861188095) / Math.Sqrt((556.4568884743647 / (19)) + (1107.815788329115 / (28))) is less than -2.0141033888794695 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (28) - 2, .025) and -0.09606276477483684 = (2188.0130985121727 - 2398.1996861188095) / 2188.0130985121727 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Tests.Perf_StringBuilder.Append_Char_Capacity(length: 100000)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 2.3086054489795913 > 2.177749192089844.
IsChangePoint: Marked as a change because one of 8/5/2022 12:58:40 PM, 11/15/2022 8:48:03 PM, 11/22/2022 2:20:42 AM falls between 11/9/2022 12:33:05 PM and 11/22/2022 2:20:42 AM.
IsRegressionStdDev: Marked as regression because -12.173025083340894 (T) = (0 -2331423.376932115) / Math.Sqrt((615139122.3983808 / (19)) + (10368983884.687943 / (28))) is less than -2.0141033888794695 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (28) - 2, .025) and -0.11704022922555754 = (2087143.6103500833 - 2331423.376932115) / 2087143.6103500833 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added refs/heads/main untriaged New issue has not been triaged by the area owner labels Nov 22, 2022
@kotlarmilos
Copy link
Member

Regression in ce58915

@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 23, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@kotlarmilos kotlarmilos transferred this issue from dotnet/perf-autofiling-issues Nov 24, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@kotlarmilos
Copy link
Member

Fixed by 5a7d46b

@jeffhandley jeffhandley added os-linux Linux OS (any supported distro) arch-x64 and removed refs/heads/main labels Dec 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-Codegen-meta-mono os-linux Linux OS (any supported distro)
Projects
None yet
Development

No branches or pull requests

4 participants