Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 5 Regressions on 11/17/2022 7:01:39 PM #78826

Closed
performanceautofiler bot opened this issue Nov 22, 2022 · 2 comments
Closed

[Perf] Linux/x64: 5 Regressions on 11/17/2022 7:01:39 PM #78826

performanceautofiler bot opened this issue Nov 22, 2022 · 2 comments
Assignees
Labels
arch-x64 area-VM-meta-mono os-linux Linux OS (any supported distro)

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 86a7ca6601d0f864b6995eabd998908954e12e51
Compare 911cc41358aa3a99c24fa85dca426fafa3bef555
Diff Diff

Regressions in System.Reflection.Attributes

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
GetCustomAttributesMethodBaseHit - Duration of single invocation 3.76 μs 4.35 μs 1.16 0.01 False
GetCustomAttributesMethodOverrideHit - Duration of single invocation 3.88 μs 4.46 μs 1.15 0.01 False
GetCustomAttributesClassHit - Duration of single invocation 15.98 μs 16.97 μs 1.06 0.01 False
GetCustomAttributesMethodBaseHitInherit - Duration of single invocation 17.78 μs 18.98 μs 1.07 0.00 False
GetCustomAttributesMethodOverrideMiss - Duration of single invocation 3.75 μs 4.49 μs 1.20 0.01 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Reflection.Attributes*'

Payloads

Baseline
Compare

Histogram

System.Reflection.Attributes.GetCustomAttributesMethodBaseHit


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 4.348718117264273 > 3.971861608173373.
IsChangePoint: Marked as a change because one of 11/17/2022 12:32:52 PM, 11/22/2022 2:20:42 AM falls between 11/9/2022 12:33:05 PM and 11/22/2022 2:20:42 AM.
IsRegressionStdDev: Marked as regression because -31.07517582583031 (T) = (0 -4492.300106086335) / Math.Sqrt((8424.45556152421 / (26)) + (2377.60917006629 / (21))) is less than -2.0141033888794695 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (26) + (21) - 2, .025) and -0.16910516304498044 = (3842.5115619077096 - 4492.300106086335) / 3842.5115619077096 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Reflection.Attributes.GetCustomAttributesMethodOverrideHit

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 4.4601427502616815 > 3.9287173638590827.
IsChangePoint: Marked as a change because one of 11/17/2022 12:32:52 PM, 11/22/2022 2:20:42 AM falls between 11/9/2022 12:33:05 PM and 11/22/2022 2:20:42 AM.
IsRegressionStdDev: Marked as regression because -37.82997930755076 (T) = (0 -4418.712180673445) / Math.Sqrt((5110.903375799018 / (26)) + (1935.7006356602883 / (21))) is less than -2.0141033888794695 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (26) + (21) - 2, .025) and -0.1702465524004894 = (3775.8813914977845 - 4418.712180673445) / 3775.8813914977845 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Reflection.Attributes.GetCustomAttributesClassHit

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 16.96512137880455 > 16.83379843600646.
IsChangePoint: Marked as a change because one of 11/17/2022 4:58:45 AM, 11/22/2022 2:20:42 AM falls between 11/9/2022 12:33:05 PM and 11/22/2022 2:20:42 AM.
IsRegressionStdDev: Marked as regression because -17.532807164948537 (T) = (0 -17009.908447353373) / Math.Sqrt((44791.4270239138 / (25)) + (15028.962263772079 / (21))) is less than -2.0153675744421933 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (25) + (21) - 2, .025) and -0.054421272254748285 = (16131.985284192728 - 17009.908447353373) / 16131.985284192728 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Reflection.Attributes.GetCustomAttributesMethodBaseHitInherit

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 18.975004117479056 > 18.72418857790094.
IsChangePoint: Marked as a change because one of 10/3/2022 2:18:04 AM, 11/17/2022 12:32:52 PM, 11/22/2022 2:20:42 AM falls between 11/9/2022 12:33:05 PM and 11/22/2022 2:20:42 AM.
IsRegressionStdDev: Marked as regression because -16.00344826706833 (T) = (0 -18930.13667380617) / Math.Sqrt((53310.14770947096 / (26)) + (26957.974400109415 / (21))) is less than -2.0141033888794695 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (26) + (21) - 2, .025) and -0.051319705472151235 = (18006.07044201134 - 18930.13667380617) / 18006.07044201134 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Reflection.Attributes.GetCustomAttributesMethodOverrideMiss

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 4.4943651608223245 > 3.9953969739725412.
IsChangePoint: Marked as a change because one of 11/17/2022 12:32:52 PM, 11/22/2022 2:20:42 AM falls between 11/9/2022 12:33:05 PM and 11/22/2022 2:20:42 AM.
IsRegressionStdDev: Marked as regression because -31.155237695262265 (T) = (0 -4493.747633851515) / Math.Sqrt((8000.523584562346 / (25)) + (2514.5706506387337 / (21))) is less than -2.0153675744421933 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (25) + (21) - 2, .025) and -0.17012296416460437 = (3840.4063260648627 - 4493.747633851515) / 3840.4063260648627 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added refs/heads/main untriaged New issue has not been triaged by the area owner labels Nov 22, 2022
@kotlarmilos
Copy link
Member

@vargaz same as #78821

@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 23, 2022
@kotlarmilos kotlarmilos transferred this issue from dotnet/perf-autofiling-issues Nov 24, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Nov 24, 2022
@jeffhandley jeffhandley added os-linux Linux OS (any supported distro) arch-x64 and removed refs/heads/main labels Dec 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-VM-meta-mono os-linux Linux OS (any supported distro)
Projects
None yet
Development

No branches or pull requests

4 participants