Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Tests.ArrayTests.CreateInstance test failing in NativeAOT #79403

Closed
jkotas opened this issue Dec 8, 2022 · 6 comments · Fixed by #79433
Closed

System.Tests.ArrayTests.CreateInstance test failing in NativeAOT #79403

jkotas opened this issue Dec 8, 2022 · 6 comments · Fixed by #79433
Labels
area-NativeAOT-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab

Comments

@jkotas
Copy link
Member

jkotas commented Dec 8, 2022

[FAIL] System.Tests.ArrayTests.CreateInstance(elementType: typeof(System.Int32*), repeatedValue: null)
Assert.Equal() Failure
Expected: 1
Actual:   2
   at System.Tests.ArrayTests.VerifyArray(Array array, Type elementType, Int32[] lengths, Int32[] lowerBounds) + 0x120
   at System.Tests.ArrayTests.VerifyArray(Array array, Type elementType, Int32[] lengths, Int32[] lowerBounds, Object repeatedValue) + 0x2c
   at System.Tests.ArrayTests.CreateInstance_Advanced(Type elementType, Int32[] lengths, Int32[] lowerBounds, Object repeatedValue) + 0xb4
   at System.Tests.ArrayTests.CreateInstance(Type elementType, Object repeatedValue) + 0x58

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=105778
Build error leg or test failing: System.Tests.ArrayTests.CreateInstance
Pull request: #79378

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "[FAIL] System.Tests.ArrayTests.CreateInstance(elementType: typeof(System.Int32*), repeatedValue: null)",
  "BuildRetry": false
}

Report

Build Definition Test Pull Request
107031 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79435
106945 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79381
106894 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79429
106767 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79021
106587 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79422
106621 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79423
106549 dotnet/runtime System.Tests.ArrayTests.CreateInstance #78189
106483 dotnet/runtime System.Tests.ArrayTests.CreateInstance #66551
106451 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79418
106356 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79385
106319 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79414
106270 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79382
106116 dotnet/runtime System.Tests.ArrayTests.CreateInstance #77597
105965 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79400
105954 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79397
105927 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79386
105651 dotnet/runtime System.Tests.ArrayTests.CreateInstance
105657 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79384
105653 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79334
105632 dotnet/runtime System.Tests.ArrayTests.CreateInstance #79349

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
20 20 20
@jkotas jkotas added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Dec 8, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 8, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Dec 8, 2022

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details
[FAIL] System.Tests.ArrayTests.CreateInstance(elementType: typeof(System.Int32*), repeatedValue: null)
Assert.Equal() Failure
Expected: 1
Actual:   2
   at System.Tests.ArrayTests.VerifyArray(Array array, Type elementType, Int32[] lengths, Int32[] lowerBounds) + 0x120
   at System.Tests.ArrayTests.VerifyArray(Array array, Type elementType, Int32[] lengths, Int32[] lowerBounds, Object repeatedValue) + 0x2c
   at System.Tests.ArrayTests.CreateInstance_Advanced(Type elementType, Int32[] lengths, Int32[] lowerBounds, Object repeatedValue) + 0xb4
   at System.Tests.ArrayTests.CreateInstance(Type elementType, Object repeatedValue) + 0x58

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=105778
Build error leg or test failing: System.Tests.ArrayTests.CreateInstance
Pull request: #79378

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "[FAIL] System.Tests.ArrayTests.CreateInstance(elementType: typeof(System.Int32*), repeatedValue: null)",
  "BuildRetry": false
}
Author: jkotas
Assignees: -
Labels:

blocking-clean-ci, untriaged, area-NativeAOT-coreclr, Known Build Error

Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Dec 8, 2022

@MichalStrehovsky Can this be a regression from your type loader cleanups?

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 9, 2022
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Dec 9, 2022
@elachlan
Copy link
Contributor

Can someone please reset the tests on the related PRs?

@MichalStrehovsky
Copy link
Member

Can someone please reset the tests on the related PRs?

I can re-trigger the test if really needed but we're generally fine merging with a failing test in the CI if the failure is understood and unlikely to be related to the PR. People with merge access know the rules.

@elachlan
Copy link
Contributor

Thanks :)

@ghost ghost locked as resolved and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants