-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracking] Mono support for InlineArrayAttribute #80798
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Does this supersede #48113? |
Good catch - I forgot about that one. 🥲 |
One interesting technical challenge is how to extract the We have already a custom attribute iterator Roughly like this:
It might also be possible to just pass the blob pointer directly to the |
The current PoC retrieves the |
I think this is generally the right direction to head in, but there are a couple of issues:
So I really think more should be delegated to the callback But overall the rest of the structure looks reasonable |
Moving to 9.0.0 |
@lambdageek Can we close this issue? |
Yep. the planned .NET 9 work is done. future work (e.g. making known custom attribute lookup faster) is tracked in follow up issues |
This issue tracks the work for implementing Mono support for
InlineArrayAttribute
#61135 and the related C# features such asparams ReadOnlySpan
, safe fixed size buffers, stackalloc of reference types, etc.Required work: Completed in .NET8
InlineArrayAttribute
This should work for the JIT/interp and also for the AOT compiler
InlineArrayAttribute
InlineArrayAttribute
inJSImport
/JSExport
Nice to have: Future Release.
(This isn't strictly necessary, but we already have a number of custom attributes that we check for on every class, and it would be nice to have a single fast lookup function (CoreCLR uses perfect hashing for this))
The text was updated successfully, but these errors were encountered: