generation of RID graph no longer works

[wfurt]

I was trying add new RID (ubuntu 23.04). I added entry to runtimeGroups.props in Microsoft.NETCore.Platforms and run dotnet.sh pack /p:UpdateRuntimeFiles=true as usually.
But no updates were made to runtime.json and runtime.compatibility.json
Release/6.0 branch still works but I experienced same issue with release/7.0.

[ghost]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I was trying add new RID (ubuntu 23.04). I added entry to runtimeGroups.props in Microsoft.NETCore.Platforms and run dotnet.sh pack /p:UpdateRuntimeFiles=true as usually.
But no updates were made to runtime.json and runtime.compatibility.json
Release/6.0 branch still works but I experienced same issue with release/7.0.

Author:	wfurt
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[carlossanlop]

6.0 PR with changes that were successfully created with the generator: #82120
7.0 PR with changes that couldn't get created with the generator: #82123

[tmds]

With .NET 7, source-build for unknown distros manages to successfully update the graph and then use that graph in the build. The task for that (GenerateRuntimeJson) is similar to the one used here (UpdateRuntimeJson).

runtime/src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj

Lines 60 to 79 in 53bb518

	<Target Name="GenerateRuntimeJson" AfterTargets="Build" Condition="'$(AdditionalRuntimeIdentifiers)' != ''">
	<MakeDir Directories="$(IntermediateOutputPath)" />
	<GenerateRuntimeGraph RuntimeGroups="@(RuntimeGroupWithQualifiers)"
	AdditionalRuntimeIdentifiers="$(AdditionalRuntimeIdentifiers)"
	AdditionalRuntimeIdentifierParent="$(AdditionalRuntimeIdentifierParent)"
	RuntimeJson="$(BaseOutputPath)runtime.json"
	UpdateRuntimeFiles="True" />
	</Target>
	<Target Name="UpdateRuntimeJson">
	<!-- Generates a Runtime graph using RuntimeGroups and diffs it with the graph described by runtime.json and runtime.compatibility.json
	Specifying UpdateRuntimeFiles=true skips the diff and updates those files.
	The graph can be visualized using the generated dmgl -->
	<MakeDir Directories="$(OutputPath)" />
	<GenerateRuntimeGraph RuntimeGroups="@(RuntimeGroupWithQualifiers)"
	RuntimeJson="runtime.json"
	CompatibilityMap="runtime.compatibility.json"
	RuntimeDirectedGraph="$(OutputPath)runtime.json.dgml"
	UpdateRuntimeFiles="$(UpdateRuntimeFiles)" />
	</Target>

[ViktorHofer]

Here's yet another PR that successfully uses the infrastructure in main: #82185. @wfurt please give it another try.

[ghost]

This issue has been marked needs-author-action and may be missing some important information.

[wfurt]

What do you want me to try? Just run the pack command as documentation suggest?
https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.NETCore.Platforms/readme.md

[ViktorHofer]

I was looking for any console indication of why it doesn't work anymore but disregard as I just found the culprit: #76068

[wfurt]

thanks for looking into it @ViktorHofer

[tmds]

See cd2f0ff#r100777231.

[tmds]

The change was also backported to 6.0 with some differences: #77510.