-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExceptionOnStartIsPropagated test failed in CI #84562
Comments
cc: @ericstj |
Tagging subscribers to this area: @dotnet/area-extensions-hosting Issue DetailsBuild InformationBuild: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=232981 Error MessageFill the error message using known issues guidance. {
"ErrorMessage": "ExceptionOnStartIsPropagated",
"BuildRetry": false,
"ErrorPattern": "",
"ExcludeConsoleLog": false
}
|
Most of the failures listed here were not the same as @stephentoub's OP issue. Many were due to the test running on a platform that didn't support RemoteExecutor (not part of default platform set) which was fixed in #84552. I was able to pull down @stephentoub's test failure and dump with:
The test was inside the service dispatcher, which I would imagine would mean the service as Started.
So waiting here: Line 69 in 018a37b
and here Line 107 in 018a37b
The service status is running:
What's interesting though, is that the service that's running is actually not
Now that test can run concurrently, since it's in another test class, but it should always create a different service - since the service name is determined by the calling method name. One thing that could happen is process ID recycling. runtime/src/libraries/Microsoft.Extensions.Hosting.WindowsServices/tests/WindowsServiceTester.cs Lines 40 to 45 in 7a57f6d
So if the process for
|
All failures here are
I'd bet that these cases the process is in the middle shutting down by the time we try to get its handle. I bet we could avoid this by either delaying start - or introducing a cross-process message like a global mutex to tell the process when it's ok to throw. |
removing blocking-clean-ci as it has not failed in 30 days
|
I don't believe this is hit at all anymore after the fix to not run in environments that don't support remote executor. Closing this out. |
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=232981
Build error leg or test failing: Microsoft.Extensions.Hosting.WindowsServiceLifetimeTests.ExceptionOnStartIsPropagated
Pull request: #84556
Error Message
Fill the error message using known issues guidance.
Report
Summary
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=323960
Error message validated:
ExceptionOnStartIsPropagated
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 6/28/2023 9:03:34 PM UTC
The text was updated successfully, but these errors were encountered: