Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jitstress] Assertion failed 'replacements[firstIndex].Overlaps(offs, size)' during 'Physical promotion' #85403

Closed
jakobbotsch opened this issue Apr 26, 2023 · 3 comments · Fixed by #85343
Closed

[jitstress] Assertion failed 'replacements[firstIndex].Overlaps(offs, size)' during 'Physical promotion' #85403

jakobbotsch opened this issue Apr 26, 2023 · 3 comments · Fixed by #85343
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes
Milestone
8.0.0

Comments

@jakobbotsch
Copy link
Member

Widespread failures in jitstress.

Example: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-85343-merge-11de8e74407345efb8/System.Text.RegularExpressions.Unit.Tests/1/console.d7f7f30f.log?helixlogtype=result

Assert failure(PID 2344 [0x00000928], Thread: 3780 [0x0ec4]): Assertion failed 'replacements[firstIndex].Overlaps(offs, size)' in 'System.Text.RegularExpressions.RegexParser:.ctor(System.String,int,System.Globalization.CultureInfo,System.Collections.Hashtable,int,System.Collections.Hashtable,System.Span`1[int]):this' during 'Physical promotion' (IL size 157; hash 0x855eb51e; FullOpts)

    File: D:\a\_work\1\s\src\coreclr\jit\promotion.cpp Line: 1317
    Image: C:\h\w\A7A6097A\p\dotnet.exe
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 26, 2023
@jakobbotsch jakobbotsch self-assigned this Apr 26, 2023
@jakobbotsch jakobbotsch added this to the 8.0.0 milestone Apr 26, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 26, 2023
@jakobbotsch jakobbotsch added blocking-clean-ci-optional Blocking optional rolling runs and removed untriaged New issue has not been triaged by the area owner labels Apr 26, 2023
@ghost
Copy link

ghost commented Apr 26, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Widespread failures in jitstress.

Example: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-85343-merge-11de8e74407345efb8/System.Text.RegularExpressions.Unit.Tests/1/console.d7f7f30f.log?helixlogtype=result

Assert failure(PID 2344 [0x00000928], Thread: 3780 [0x0ec4]): Assertion failed 'replacements[firstIndex].Overlaps(offs, size)' in 'System.Text.RegularExpressions.RegexParser:.ctor(System.String,int,System.Globalization.CultureInfo,System.Collections.Hashtable,int,System.Collections.Hashtable,System.Span`1[int]):this' during 'Physical promotion' (IL size 157; hash 0x855eb51e; FullOpts)

    File: D:\a\_work\1\s\src\coreclr\jit\promotion.cpp Line: 1317
    Image: C:\h\w\A7A6097A\p\dotnet.exe
Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch added the JitStress CLR JIT issues involving JIT internal stress modes label Apr 26, 2023
@EgorBo EgorBo mentioned this issue Apr 26, 2023
Merged
@EgorBo
Copy link
Member

EgorBo commented Apr 26, 2023 •
edited
Loading

Also

Assertion failed '(unsigned)TypeGet(value) < ArrLen(genTypeSizes)' in 
'System.Text.RegularExpressions.RegexParser:.ctor(System.String,int,System.Globalization.CultureInfo,System.Collections.
Hashtable,int,System.Collections.Hashtable,System.Span`1[int]):this' during 'Physical promotion'

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-85389-merge-358d698db7054f0c97/JIT.1/1/console.22303217.log?helixlogtype=result

@jakobbotsch jakobbotsch mentioned this issue Apr 26, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 26, 2023
@jakobbotsch
Copy link
Member Author

It's the same underlying issue -- there is an out-of-bounds indexing that can manifest in a few different ways. #85343 has the fix.

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 26, 2023
This was referenced Apr 27, 2023
Closed
Closed
@jakobbotsch jakobbotsch mentioned this issue May 15, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix physical promotion scenario name and a couple of bugs jakobbotsch/runtime
2 participants
@EgorBo @jakobbotsch