Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SearchValues<string> in Regex #85693

Closed
stephentoub opened this issue May 3, 2023 · 2 comments
Closed

Use SearchValues<string> in Regex #85693

stephentoub opened this issue May 3, 2023 · 2 comments

Comments

@stephentoub
Copy link
Member

stephentoub commented May 3, 2023

Once SearchValues.Create(ReadOnlySpan<string>, StringComparison) is available, we can use it in Regex to accelerate the search for patterns that begin with alternations, sets, etc.

@ghost
Copy link

ghost commented May 3, 2023

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Once IndexOfAnyValues.Create(ReadOnlySpan<string>, StringComparison) is available, we can use it in Regex to accelerate the search for patterns that begin with alternations, sets, etc.

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Text.RegularExpressions

Milestone: 8.0.0

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 5, 2023
@stephentoub stephentoub changed the title Use IndexOfAnyValues<string> in Regex Use SearchValues<string> in Regex Jul 5, 2023
@stephentoub stephentoub modified the milestones: 8.0.0, 9.0.0 Aug 9, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 26, 2023
@stephentoub
Copy link
Member Author

SearchValues<string> is being used now by regex for case-insensitive. We can opportunistically add in use for case-sensitive as we find worthwhile cases for it.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant