Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify tryrun scripts #86829

Open
MichalStrehovsky opened this issue May 27, 2023 · 8 comments
Open

Unify tryrun scripts #86829

MichalStrehovsky opened this issue May 27, 2023 · 8 comments

Comments

@MichalStrehovsky
Copy link
Member

#86781 (comment)

We have tryrun.cmake that is mostly used for -cross builds.

Then we have similar things in runtime/src/native/libs/configure.cmake and https://github.com/dotnet/runtime/blob/main/eng/native/tryrun_ios_tvos.cmake.

We should reconcile this.

Related: #56622

@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 27, 2023
@ghost
Copy link

ghost commented May 27, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

#86781 (comment)

We have tryrun.cmake that is mostly used for -cross builds.

Then we have similar things in runtime/src/native/libs/configure.cmake and https://github.com/dotnet/runtime/blob/main/eng/native/tryrun_ios_tvos.cmake.

We should reconcile this.

Related: #56622

Author: MichalStrehovsky
Assignees: -
Labels:

area-Infrastructure-libraries, os-android

Milestone: -

@janvorli
Copy link
Member

@MichalStrehovsky the tryrun.cmake contains values for cross build that the configure.cmake would detect if the build was executed on the target OS. It is used only for checks that execute code, so they cannot be evaluated on the build hosting OS. This is a cmake concept - the tryrun.cmake is meant to be separate, as it is loaded by cmake as an initialization of its cache.
It is not clear to me how we could reasonably unify these.

@MichalStrehovsky
Copy link
Member Author

@MichalStrehovsky the tryrun.cmake contains values for cross build that the configure.cmake would detect if the build was executed on the target OS. It is used only for checks that execute code, so they cannot be evaluated on the build hosting OS.

Yes, it's the same thing that the quoted part of configure.cmake is also doing. It's not clear why we spread these around the codebase

@janvorli
Copy link
Member

Oh, I am surprised to see it in the configure.cmake in libraries. The ones in coreclr don't have that, they use the tryrun.cmake.

@ViktorHofer ViktorHofer added this to the 8.0.0 milestone Jun 7, 2023
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Jun 7, 2023
@ViktorHofer
Copy link
Member

@akoeplinger as you are assigned, should this stay in 8.0.0 or be moved?

@akoeplinger
Copy link
Member

@ViktorHofer it can stay in 8.0 for now

@ilonatommy
Copy link
Member

@akoeplinger, this looks like a fast cleanup issue, will you have capacity for it?

@akoeplinger
Copy link
Member

Hopefully 😄

@ViktorHofer ViktorHofer modified the milestones: 9.0.0, 10.0.0 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants