-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify tryrun scripts #86829
Comments
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsWe have tryrun.cmake that is mostly used for Then we have similar things in runtime/src/native/libs/configure.cmake and https://github.com/dotnet/runtime/blob/main/eng/native/tryrun_ios_tvos.cmake. We should reconcile this. Related: #56622
|
@MichalStrehovsky the |
Yes, it's the same thing that the quoted part of configure.cmake is also doing. It's not clear why we spread these around the codebase |
Oh, I am surprised to see it in the configure.cmake in libraries. The ones in coreclr don't have that, they use the tryrun.cmake. |
@akoeplinger as you are assigned, should this stay in 8.0.0 or be moved? |
@ViktorHofer it can stay in 8.0 for now |
@akoeplinger, this looks like a fast cleanup issue, will you have capacity for it? |
Hopefully 😄 |
#86781 (comment)
We have tryrun.cmake that is mostly used for
-cross
builds.Then we have similar things in runtime/src/native/libs/configure.cmake and https://github.com/dotnet/runtime/blob/main/eng/native/tryrun_ios_tvos.cmake.
We should reconcile this.
Related: #56622
The text was updated successfully, but these errors were encountered: