Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing all the resx schema unnecessary comments auto added by Visual Studio #86906

Open
carlossanlop opened this issue May 30, 2023 · 3 comments
Labels
area-Infrastructure-libraries tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Milestone

Comments

@carlossanlop
Copy link
Member

We are inconsistent in keeping or removing the unnecessary comments that are automatically added by Visyual Studio at the beginning of resx files.

It's not clear if we would open an issue in another repo, but we can manually address this in dotnet/runtime if we want.

Here is the full conversation where the details were discussed: #85491 (comment)

@ghost
Copy link

ghost commented May 30, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

We are inconsistent in keeping or removing the unnecessary comments that are automatically added by Visyual Studio at the beginning of resx files.

It's not clear if we would open an issue in another repo, but we can manually address this in dotnet/runtime if we want.

Here is the full conversation where the details were discussed: #85491 (comment)

Author: carlossanlop
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 30, 2023
@eerhardt
Copy link
Member

Note that we shouldn't do this unless VS stops adding it to the .resx file. I hate "fighting" VS. It would be really annoying to have to manually delete this section every time I changed a .resx file in a PR.

@danmoseley
Copy link
Member

Yes unfortunately this realistically needs to be fixed in VS first. And VS probably uses the .NET Framework ResourceWriter, which can't reasonably be changed now, so it would have to do some tricks like editing the file before saving it.

More power to anyone who has a go at driving that on the VS side. 🙂

@ViktorHofer ViktorHofer added this to the Future milestone Jun 28, 2023
@ViktorHofer ViktorHofer added tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly and removed untriaged New issue has not been triaged by the area owner labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure-libraries tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Projects
None yet
Development

No branches or pull requests

4 participants