Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit the strategy for fail fasts from compInlineResult->NoteFatal. #8713

Open
sandreenko opened this issue Aug 8, 2017 · 1 comment
Open

Revisit the strategy for fail fasts from compInlineResult->NoteFatal. #8713

sandreenko opened this issue Aug 8, 2017 · 1 comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI design-discussion Ongoing discussion about design without consensus enhancement Product code improvement that does NOT require public API changes/additions
Milestone
Future

Comments

@sandreenko
Copy link
Contributor

We do not have handlers for compDonotInline after some functions, that do "NoteFatal". For example after lvaGrabTemp. It creates problem, if we do NoteFatal for the second time, it blows the assert that compilation should be already interrupted.
There are two obvious solutions:

  1. delete the assert and allow to continue execution with several "NoteFatal" before a handler;
  2. do fail-fast check after the each function, that can do "NoteFatal".

The first will waste time for the work, that will be thrown out.
The second will need new intrusive checks in many places.

Attach dotnet/coreclr#13271 .

category:correctness
theme:inlining
skill-level:expert
cost:medium
@RussKeldorph
Copy link
Contributor

@dotnet/jit-contrib

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@sandreenko sandreenko removed the JitUntriaged CLR JIT issues needing additional triage label Jan 4, 2021
@AndyAyersMS AndyAyersMS mentioned this issue Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI design-discussion Ongoing discussion about design without consensus enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@msftgits @BruceForstall @RussKeldorph @sandreenko