Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][globalization][icu] Refactor GlobalizationNative_IndexOfNative function #87767

Closed
Tracked by #80689
mkhamoyan opened this issue Jun 19, 2023 · 2 comments
Closed
Tracked by #80689

[iOS][globalization][icu] Refactor GlobalizationNative_IndexOfNative function #87767

mkhamoyan opened this issue Jun 19, 2023 · 2 comments
Assignees
@mkhamoyan
Labels
area-System.Globalization os-ios Apple iOS
Milestone
Future

Comments

@mkhamoyan
Copy link
Contributor

mkhamoyan commented Jun 19, 2023 •
edited
Loading

GlobalizationNative_IndexOfNative was implemented by #86895 .
Investigate if possible to use GlobalizationNative_StartsWithNative function inside GlobalizationNative_IndexOfNative

Contributes to #80689
@mkhamoyan mkhamoyan self-assigned this Jun 19, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 19, 2023
@ghost
Copy link

ghost commented Jun 19, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Investigate if it is possible to implement IsPrefix and IsSuffix to support returning matchLengthPtr on OSX.

Contributes to 80689

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

area-System.Globalization, os-ios
Milestone: -

This was referenced May 24, 2023
Closed
Merged
@mkhamoyan mkhamoyan changed the title [iOS][globalization][icu] Investigate if IsPrefix and IsSuffix can return matchLengthPtr [iOS][globalization][icu] Refactor GlobalizationNative_IndexOfNative function Jun 19, 2023
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Jul 24, 2023
@marek-safar marek-safar added this to the Future milestone Jul 24, 2023
@mkhamoyan
Copy link
Contributor Author

Current implementation of GlobalizationNative_IndexOfNative has not caused any issues so far. Therefore, closing this ticket for now.

If performance concerns or any other issues arise in the future, we can open a new issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mkhamoyan mkhamoyan

Labels
area-System.Globalization os-ios Apple iOS
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@marek-safar @mkhamoyan