Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: win-arm64 native varargs doesn't correctly split incoming vectors between register and stack #89595

Closed
markples opened this issue Jul 27, 2023 · 1 comment · Fixed by #90712
Closed

JIT: win-arm64 native varargs doesn't correctly split incoming vectors between register and stack #89595

markples opened this issue Jul 27, 2023 · 1 comment · Fixed by #90712
Assignees
@BruceForstall
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows Priority:3 Work that is nice to have
Milestone
8.0.0

Comments

@markples
Copy link
Member

markples commented Jul 27, 2023 •
edited by BruceForstall
Loading

from the Runtime_71375.cs test source:

        // At the time of writing this test, the calling convention for incoming vector parameters on
        // Windows ARM64 was broken, so only the fact that "Problem" compiled without asserts was
        // checked. If/once the above is fixed, this test should be changed to actually call "Problem".
@markples markples added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 27, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 27, 2023
@ghost
Copy link

ghost commented Jul 27, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

from the test source:

        // At the time of writing this test, the calling convention for incoming vector parameters on
        // Windows ARM64 was broken, so only the fact that "Problem" compiled without asserts was
        // checked. If/once the above is fixed, this test should be changed to actually call "Problem".
Author: markples
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Jul 28, 2023
@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Jul 28, 2023
@JulieLeeMSFT JulieLeeMSFT added the Priority:3 Work that is nice to have label Jul 31, 2023
@JulieLeeMSFT JulieLeeMSFT assigned BruceForstall and unassigned TIHan Aug 7, 2023
@BruceForstall BruceForstall mentioned this issue Aug 11, 2023
Closed
@BruceForstall BruceForstall changed the title JIT: fully enable Runtime_71375.cs test JIT: win-arm64 native varargs doesn't correctly split incoming vectors between register and stack Aug 16, 2023
@BruceForstall BruceForstall mentioned this issue Aug 17, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 17, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BruceForstall BruceForstall

Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows Priority:3 Work that is nice to have
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix win-arm64 native varargs ABI BruceForstall/runtime
4 participants
@TIHan @BruceForstall @markples @JulieLeeMSFT