Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DebuggerTypeProxy for ListDictionaryInternal #91254

Closed
JamesNK opened this issue Aug 29, 2023 · 4 comments · Fixed by #91355
Closed

Add DebuggerTypeProxy for ListDictionaryInternal #91254

JamesNK opened this issue Aug 29, 2023 · 4 comments · Fixed by #91355

Comments

@JamesNK
Copy link
Member

JamesNK commented Aug 29, 2023

This PR added debugger display to ListDictionaryInternal. A DebuggerTypeProxy should also be added to improve displaying the collection's contents.

The current display in VS:
image

For example:

internal sealed class ArrayListDebugView
{
private readonly ArrayList _arrayList;
public ArrayListDebugView(ArrayList arrayList)
{
ArgumentNullException.ThrowIfNull(arrayList);
_arrayList = arrayList;
}
[DebuggerBrowsable(DebuggerBrowsableState.RootHidden)]
public object?[] Items => _arrayList.ToArray();
}

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 29, 2023
@ghost
Copy link

ghost commented Aug 29, 2023

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR added debugger display to ListDictionaryInternal. A DebuggerTypeProxy should also be added to improve displaying the collection's contents.

The current display in VS:
image

For example:

Author: JamesNK
Assignees: -
Labels:

area-System.Collections, untriaged

Milestone: -

@tarekgh
Copy link
Member

tarekgh commented Aug 29, 2023

@arturek are you interested to submit a PR for this one too?

@tarekgh tarekgh added this to the Future milestone Aug 29, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 29, 2023
@arturek
Copy link
Contributor

arturek commented Aug 29, 2023

@tarekgh yes, thanks. I wrote the code, but I cannot find ListDictionaryInternal's unit tests.

@tarekgh
Copy link
Member

tarekgh commented Aug 29, 2023

@arturek ListDictionaryInternal is an internal thingy, so I don't think we have unit tests for it. Can't you test it through the Exception class? or add new tests for it if needed.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 30, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 6, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants