Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][mt][hybrid] TestJapaneseCalendarDateParsing, PMDesignator_Get_ReturnsExpected_HybridGlobalization #95795

Open
pavelsavara opened this issue Dec 8, 2023 · 2 comments
Open

[browser][mt][hybrid] TestJapaneseCalendarDateParsing, PMDesignator_Get_ReturnsExpected_HybridGlobalization #95795

pavelsavara opened this issue Dec 8, 2023 · 2 comments
Assignees
@ilonatommy
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Milestone
Future

Comments

@pavelsavara
Copy link
Member

System.Globalization.Calendars.Hybrid.WASM.Tests and System.Globalization.Hybrid.WASM.Tests are failing few tests when running on threadpool thread in MT build.

[16:43:30] info: [2023-12-08T16:43:30.656Z] [FAIL] System.Globalization.Tests.ChineseLunisolarCalendarTests.TestJapaneseCalendarDateParsing
[16:43:30] info: System.Exception : Error: Cannot change case, the culture name is null.
[16:43:30] info:     at sd (http://127.0.0.1:44583/_framework/dotnet.runtime.js:3:215734)
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[237]:0x16d9d
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[268]:0x19c8f
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[307]:0x27633
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[3338]:0xfa9e9
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[2605]:0xcc8f1
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[2604]:0xcc881
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[1962]:0xa7520
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[348]:0x2928e
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[277]:0x269a5
[16:43:30] info:    at System.Globalization.TextInfo.JsChangeCase(Char* src, Int32 srcLen, Char* dstBuffer, Int32 dstBufferCapacity, Boolean toUpper)
[16:43:30] info:    at System.Globalization.TextInfo.ChangeCaseCore(Char* src, Int32 srcLen, Char* dstBuffer, Int32 dstBufferCapacity, Boolean bToUpper)
[16:43:30] info:    at System.Globalization.TextInfo.ChangeCase(Char c, Boolean toUpper)
[16:43:30] info:    at System.Globalization.TextInfo.ToLower(Char c)
[16:43:30] info:    at System.Globalization.DateTimeFormatInfo.Tokenize(TokenType TokenMask, TokenType& tokenType, Int32& tokenValue, __DTString& str)
[16:43:30] info:    at System.__DTString.GetRegularToken(TokenType& tokenType, Int32& tokenValue, DateTimeFormatInfo dtfi)
[16:43:30] info:    at System.DateTimeParse.Lex(DS dps, __DTString& str, DateTimeToken& dtok, DateTimeRawInfo& raw, DateTimeResult& result, DateTimeFormatInfo& dtfi, DateTimeStyles styles)
[16:43:30] info:    at System.DateTimeParse.TryParse(ReadOnlySpan`1 s, DateTimeFormatInfo dtfi, DateTimeStyles styles, DateTimeResult& result)
[16:43:30] info:    at System.DateTimeParse.Parse(ReadOnlySpan`1 s, DateTimeFormatInfo dtfi, DateTimeStyles styles)
[16:43:30] info:    at System.DateTime.Parse(String s, IFormatProvider provider)
[16:43:30] info:    at System.Globalization.Tests.CalendarTestBase.TestJapaneseCalendarDateParsing()
[16:43:30] info:    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[16:43:30] info:    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Log

[16:44:14] info: [2023-12-08T16:44:14.622Z] [FAIL] System.Globalization.Tests.DateTimeFormatInfoPMDesignator.PMDesignator_Get_ReturnsExpected_HybridGlobalization(format: DateTimeFormatInfo { AbbreviatedDayNames = ["Sun", "Mon", "Tue", "Wed", "Thu", ···], AbbreviatedMonthGenitiveNames = ["Jan", "Feb", "Mar", "Apr", "May", ···], AbbreviatedMonthNames = ["Jan", "Feb", "Mar", "Apr", "May", ···], AMDesignator = "AM", Calendar = GregorianCalendar { AlgorithmType = SolarCalendar, CalendarType = Localized, Eras = [···], IsReadOnly = False, MaxSupportedDateTime = 9999-12-31T23:59:59.9999999, ··· }, ··· }, value: "pm")
[16:44:14] info: Assert.Equal() Failure: Strings differ
[16:44:14] info:            ↓ (pos 0)
[16:44:14] info: Expected: "pm"
[16:44:14] info: Actual:   "PM"
[16:44:14] info:            ↑ (pos 0)
[16:44:14] info:    at System.Object.InvokeStub_DateTimeFormatInfoPMDesignator.PMDesignator_Get_ReturnsExpected_HybridGlobalization(Object , Span`1 )
[16:44:14] info:    at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Log
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Globalization os-browser Browser variant of arch-wasm labels Dec 8, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Dec 8, 2023
@ghost
Copy link

ghost commented Dec 8, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Globalization.Calendars.Hybrid.WASM.Tests and System.Globalization.Hybrid.WASM.Tests are failing few tests when running on threadpool thread in MT build.

[16:43:30] info: [2023-12-08T16:43:30.656Z] [FAIL] System.Globalization.Tests.ChineseLunisolarCalendarTests.TestJapaneseCalendarDateParsing
[16:43:30] info: System.Exception : Error: Cannot change case, the culture name is null.
[16:43:30] info:     at sd (http://127.0.0.1:44583/_framework/dotnet.runtime.js:3:215734)
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[237]:0x16d9d
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[268]:0x19c8f
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[307]:0x27633
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[3338]:0xfa9e9
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[2605]:0xcc8f1
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[2604]:0xcc881
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[1962]:0xa7520
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[348]:0x2928e
[16:43:30] info:     at http://127.0.0.1:44583/_framework/dotnet.native.wasm:wasm-function[277]:0x269a5
[16:43:30] info:    at System.Globalization.TextInfo.JsChangeCase(Char* src, Int32 srcLen, Char* dstBuffer, Int32 dstBufferCapacity, Boolean toUpper)
[16:43:30] info:    at System.Globalization.TextInfo.ChangeCaseCore(Char* src, Int32 srcLen, Char* dstBuffer, Int32 dstBufferCapacity, Boolean bToUpper)
[16:43:30] info:    at System.Globalization.TextInfo.ChangeCase(Char c, Boolean toUpper)
[16:43:30] info:    at System.Globalization.TextInfo.ToLower(Char c)
[16:43:30] info:    at System.Globalization.DateTimeFormatInfo.Tokenize(TokenType TokenMask, TokenType& tokenType, Int32& tokenValue, __DTString& str)
[16:43:30] info:    at System.__DTString.GetRegularToken(TokenType& tokenType, Int32& tokenValue, DateTimeFormatInfo dtfi)
[16:43:30] info:    at System.DateTimeParse.Lex(DS dps, __DTString& str, DateTimeToken& dtok, DateTimeRawInfo& raw, DateTimeResult& result, DateTimeFormatInfo& dtfi, DateTimeStyles styles)
[16:43:30] info:    at System.DateTimeParse.TryParse(ReadOnlySpan`1 s, DateTimeFormatInfo dtfi, DateTimeStyles styles, DateTimeResult& result)
[16:43:30] info:    at System.DateTimeParse.Parse(ReadOnlySpan`1 s, DateTimeFormatInfo dtfi, DateTimeStyles styles)
[16:43:30] info:    at System.DateTime.Parse(String s, IFormatProvider provider)
[16:43:30] info:    at System.Globalization.Tests.CalendarTestBase.TestJapaneseCalendarDateParsing()
[16:43:30] info:    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[16:43:30] info:    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Log

[16:44:14] info: [2023-12-08T16:44:14.622Z] [FAIL] System.Globalization.Tests.DateTimeFormatInfoPMDesignator.PMDesignator_Get_ReturnsExpected_HybridGlobalization(format: DateTimeFormatInfo { AbbreviatedDayNames = ["Sun", "Mon", "Tue", "Wed", "Thu", ···], AbbreviatedMonthGenitiveNames = ["Jan", "Feb", "Mar", "Apr", "May", ···], AbbreviatedMonthNames = ["Jan", "Feb", "Mar", "Apr", "May", ···], AMDesignator = "AM", Calendar = GregorianCalendar { AlgorithmType = SolarCalendar, CalendarType = Localized, Eras = [···], IsReadOnly = False, MaxSupportedDateTime = 9999-12-31T23:59:59.9999999, ··· }, ··· }, value: "pm")
[16:44:14] info: Assert.Equal() Failure: Strings differ
[16:44:14] info:            ↓ (pos 0)
[16:44:14] info: Expected: "pm"
[16:44:14] info: Actual:   "PM"
[16:44:14] info:            ↑ (pos 0)
[16:44:14] info:    at System.Object.InvokeStub_DateTimeFormatInfoPMDesignator.PMDesignator_Get_ReturnsExpected_HybridGlobalization(Object , Span`1 )
[16:44:14] info:    at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Log

Author: pavelsavara
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization, os-browser
Milestone: 9.0.0

@pavelsavara pavelsavara mentioned this issue Dec 8, 2023
Closed
31 tasks
@ilonatommy
Copy link
Member

Most probably will get fixed with #98483.

@ilonatommy ilonatommy mentioned this issue May 23, 2024
Closed
23 tasks
@ilonatommy ilonatommy modified the milestones: 9.0.0, Future Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@pavelsavara @ilonatommy