-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XUnitLogChecker: runtime-libraries-coreclr outerloop
tests are unable to find the tool DLL
#96035
Comments
Tagging subscribers to this area: @hoyosjs Issue DetailsError Blob{
"ErrorMessage": "XUnitLogChecker.dll does not exist in the expected location:",
"BuildRetry": false,
"ErrorPattern": "",
"ExcludeConsoleLog": false
} Reproduction Steps
|
Might have to do with how the interop generator test payloads are generated? |
Has there been any progress on this? This is blocking Known Build Errors on outerloop pipelines because too many test failures are reported in AzDO and legit test failures end up not getting processed by the bot. See discussion on #96481 (comment) for more info. |
I think I know what's going on... The regular libraries runs build the product (including XUnitLogChecker) in one job, push it to the feed, and then later it is downloaded and consumed by the job that runs the tests. In outerloop, we build the product in the same job, in a previous step before the test running step. We aren't building XUnitLogChecker in that build step. I'm now trying to figure out where and how to add XUnitLogChecker so it builds in outerloop jobs too. |
Looks like XunitLogChecker is normally build by libs\tests.proj. This is built in both the regular build and in the outerloop build, however during the outerloop build it seems that the condition to inlcude the checker project is false. We looked into why this is happening - it's because So this is false: runtime/src/libraries/tests.proj Lines 759 to 763 in b8e1296
In outerloop no
But in the regular libraries build it will be:
To fix this we should see if we can just update the condition for including the log checker CSProj to not depend on BuildTargetFramework. Maybe TargetFrameworkIdentifier is sufficient (if we were trying to filter to |
Error Blob
Reproduction Steps
runtime-libraries-coreclr outerloop
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=498370
Error message validated:
XUnitLogChecker.dll does not exist in the expected location:
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 12/14/2023 6:12:51 PM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: