Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for server OCSP stapling. #96791

Closed
rzikm opened this issue Jan 10, 2024 · 2 comments
Closed

Add test coverage for server OCSP stapling. #96791

rzikm opened this issue Jan 10, 2024 · 2 comments
Assignees
@rzikm
Labels
area-System.Net.Security test-enhancement Improvements of test source code
Milestone
9.0.0

Comments

@rzikm
Copy link
Member

rzikm commented Jan 10, 2024

We are missing test coverage on the logic in SslStreamCertificateContext.Linux which maintains an OCSP staple to send out during TLS handshake when given SslStreamCertificateContext is used in server SslStream instance.

Make sure we prevent regression of at least these issues:
@ghost
Copy link

ghost commented Jan 10, 2024

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

We are missing test coverage on the logic in SslStreamCertificateContext.Linux which maintains an OCSP staple to send out during TLS handshake when given SslStreamCertificateContext is used in server SslStream instance.

Make sure we prevent regression of at least these issues:

Author: rzikm
Assignees: -
Labels:

area-System.Net.Security
Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 10, 2024
@rzikm rzikm added this to the 9.0.0 milestone Jan 10, 2024
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 10, 2024
This was referenced Jan 10, 2024
Merged
Merged
@karelz karelz added the test-enhancement Improvements of test source code label Jan 11, 2024
@rzikm rzikm changed the title Test coverage for server OCSP stapling. Add test coverage for server OCSP stapling. Jan 11, 2024
@rzikm rzikm self-assigned this Jan 16, 2024
@rzikm
Copy link
Member Author

rzikm commented Jan 31, 2024

Fixed by #97099

@rzikm rzikm closed this as completed Jan 31, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzikm rzikm

Labels
area-System.Net.Security test-enhancement Improvements of test source code
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
2 participants
@karelz @rzikm